functional readonly_cli tests pass with incorrect input

Bug #1458932 reported by Anton Arefiev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Undecided
Anton Arefiev

Bug Description

Functional readonly_cli tests checks resources attribute for diff cinder cmds, the problem is that they are always false positive.

The root cause of the problem is parser.listing method return empty list if env doesn't have resources, so assertTableStruct always passes.

Tags: tests
Anton Arefiev (aarefiev)
Changed in python-cinderclient:
assignee: nobody → Anton Arefiev (aarefiev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/185660

Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/185660
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=d547d2779aab59a100eed0d0c15b4b4b85d37b59
Submitter: Jenkins
Branch: master

commit d547d2779aab59a100eed0d0c15b4b4b85d37b59
Author: Anton Arefiev <email address hidden>
Date: Tue May 26 19:22:32 2015 +0300

    Fix functional readonly_cli tests

    Parser.listing method return empty list if env doesn't have resources,
    so assertTableStruct works wrong, doesn't check field names in the
    output table.

    This change add new assert(assertTableHeaders) to check resource
    attributes.

    Change-Id: Ieca67b5cc2202467527c5a2dfbd7b2f2b4d5ad8d
    Closes-Bug: #1458932

Changed in python-cinderclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
Eric Harney (eharney)
tags: added: tests
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.