cinderclient deprecated endpoint_type needs dest=

[Scott DAngelo]

Fix for https://bugs.launchpad.net/python-cinderclient/+bug/1453901 did not set dest=os_endpoint_type for synonym endpoint_type

needs:
diff --git a/cinderclient/shell.py b/cinderclient/shell.py
index fa7c916..d68d88c 100644
--- a/cinderclient/shell.py
+++ b/cinderclient/shell.py
@@ -169,6 +169,7 @@ class OpenStackCinderShell(object):
                             default=DEFAULT_CINDER_ENDPOINT_TYPE),
                             help='DEPRECATED! Use --os-endpoint-type.')
         parser.add_argument('--endpoint_type',
+ dest='os_endpoint_type',
                             help=argparse.SUPPRESS)

[Sean McGinnis (sean-mcginnis)]

Automatically unassigning due to inactivity.

[Sean McGinnis (sean-mcginnis)]

Scott, is there still work to do here?

[Scott DAngelo (scott-dangelo)]

No, I think we can and should just remove os_enpoint_type as it's been deprecated over 1 year.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/351880
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=a33d87fb424455f05d6713993c9254c20f8f96a4
Submitter: Jenkins
Branch: master

commit a33d87fb424455f05d6713993c9254c20f8f96a4
Author: Nate Potter <email address hidden>
Date: Fri Aug 5 18:33:56 2016 +0000

    Update --endpoint-type dest to os_endpoint_type

    Currently the dest of the deprecated --endpoint-type arg
    is 'endpoint_type'. However, the code only uses 'os_endpoint_type'
    so right now it isn't being used at all. This patch updates
    the dest to be 'os_endpoint_type' so that the variable can
    be assigned correctly.

    Change-Id: Ie8592d12bcf95e4ccff571e831440b18f5acfd40
    Closes-bug: #1454436

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-cinderclient 1.10.0 release.