Remove all TODOs comments from code

Bug #1371577 reported by Ivan Kolodyazhny
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Invalid
Undecided
Unassigned

Bug Description

Go through every TODO in the code, and either turn it into a bug or remove it

Etherpad doc is here: https://etherpad.openstack.org/p/cinder-kilo-todos-cleanup

Ivan Kolodyazhny (e0ne)
Changed in python-cinderclient:
status: New → Confirmed
status: Confirmed → New
Changed in python-cinderclient:
assignee: nobody → Imran Hayder (hayderimran7)
Revision history for this message
Imran Hayder (hayderimran7) wrote :

https://review.openstack.org/#/c/126993/
Though i removed all the TODOs comments and committed , change is abandoned since a reviewer added that too much subtle info there is in TODOs, removing all these comments wont add anything meaningful.
See comments in above review link.

Also, read the 'pylintrc' file in cinder repo, it clearly says 'TODOs are fine to be added as comments'

Changed in python-cinderclient:
assignee: Imran Hayder (hayderimran7) → nobody
Changed in python-cinderclient:
assignee: nobody → Roman Vasilets (rvasilets)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134574

Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-cinderclient (master)

Change abandoned by Roman Vasilets (<email address hidden>) on branch: master
Review: https://review.openstack.org/134574

Changed in python-cinderclient:
assignee: Roman Vasilets (rvasilets) → nobody
Revision history for this message
Sean McGinnis (sean-mcginnis) wrote :

Only a small number of TODOs in the client code now, and most of them should probably stay as notes for things to think about in the future. I think these and any others will have to be handled on a case by case basis, so closing this bug as invalid as I don't think we want to do a blanket removal of all instances at this point.

Changed in python-cinderclient:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.