Find Broken for v2 volumes and snapshots

[Terry Howe]

The manager find is broken for volumes and snapshots because they use display_name rather that name for v2.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/80672

[Mike Perez (thingee)]

The bug description didn't really make sense to me. In the patch I see you're touching v1. I tried doing a find both by uuid/name in v1 on volumes and snapshot and didn't have problems.

http://paste.openstack.org/show/73534

[Terry Howe (thowe-g)]

Mike, this is the hack in cinderclient that works around the problem:

https://github.com/openstack/python-cinderclient/blob/master/cinderclient/utils.py#L220

I was fixing this for the unified CLI where find by name does not work for these cases. I don't think the solution in utils.py is a good idea, it just causes extra REST calls for everything else.

[Terry Howe (thowe-g)]

Uggh, I pasted in the wrong line number

https://github.com/openstack/python-cinderclient/blob/master/cinderclient/utils.py#L224

[Ryan McNair (rdmcnair)]

This seems to be fixed with https://review.openstack.org/#/c/223067/8/cinderclient/v2/volume_snapshots.py