Malformed encryption-type body in test cases

Bug #1286261 reported by Peter Hamilton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Undecided
Peter Hamilton

Bug Description

Files: cinderclient.tests.v1.test_volume_encryption_types, ditto v2
Method: test_create
Bug: malformed encryption-type body

The dictionary containing encryption-type information for encryption-type creation wraps the body under the dictionary key 'encryption'. This is actually unnecessary, since the underlying encryption-type create method does this wrapping already. Unfortunately, the impacted test cases still pass, since the actual passing of the body to cinder does not happen in these test cases.

Fix: remove the dictionary key 'encryption' and just pass the dictionary containing the encryption-type information

Changed in python-cinderclient:
assignee: nobody → Peter Hamilton (peter-hamilton)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77235

Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/77235
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=51ffb26437071e90a236767bc18d63bc7cabc2ce
Submitter: Jenkins
Branch: master

commit 51ffb26437071e90a236767bc18d63bc7cabc2ce
Author: Peter Hamilton <email address hidden>
Date: Fri Feb 28 13:09:27 2014 -0500

    Fix malformed encryption-type body in test cases

    This change addresses bug #1286261 and fixes two malformed
    encryption-type bodies in two test_create test cases.

    Change-Id: I308561c1d5a70812889a93922e13194597f670f1
    Closes-Bug: #1286261

Changed in python-cinderclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.