remove testr init from run_tests.sh

Bug #1220147 reported by Kui Shi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
Undecided
Kui Shi

Bug Description

Don't need to init testr explicitly

In run_tests.sh, function init_testr will initialize testr if the
directory .testrepository is not existed. Actually, testr will do
the check before run the test:

In Python package testrepository, setuptools_command.py:Testr.run

68 def run(self):
69 """Set up testr repo, then run testr"""
70 if not os.path.isdir(".testrepository"):
71 self._run_testr("init")

So, init_testr can be removed safely.

Kui Shi (skuicloud)
Changed in python-cinderclient:
assignee: nobody → Kui Shi (skuicloud)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/44841

Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
Kui Shi (skuicloud) wrote :

only "python setup.py testr" will trigger the function to create .testrepository if not exist.
run "testr run" directly will not trigger it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/44841
Committed: http://github.com/openstack/python-cinderclient/commit/b757c348b758fb5517cc0a08675b6c3ae8a7538e
Submitter: Jenkins
Branch: master

commit b757c348b758fb5517cc0a08675b6c3ae8a7538e
Author: Kui Shi <email address hidden>
Date: Tue Sep 3 04:39:24 2013 +0800

    Don't need to init testr explicitly

    In run_tests.sh, function init_testr will initialize testr if the
    directory .testrepository is not existed. Actually, testr will do
    the check before run the test:

    In Python package testrepository, setuptools_command.py:Testr.run

    68 def run(self):
    69 """Set up testr repo, then run testr"""
    70 if not os.path.isdir(".testrepository"):
    71 self._run_testr("init")

    So, init_testr can be removed safely.

    Fixes Bug #1220147

    Change-Id: Ide99a836cd601453624c7a562b7256c86bd46811

Changed in python-cinderclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.