tarball's are missing files (setuptools-git was removed)

Bug #1118511 reported by Dan Prince
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-cinderclient
Fix Released
High
Dan Prince

Bug Description

In 81cbbcc4e01c81084c352f7fc1ecea149089a2b9 we removed:

setup_requires=['setuptools-git>=0.4'],

from setup.py.

Now when I generate tarballs using 'python setup.py sdist' they are missing files.

After talking about it on IRC we think leaving setuptools-git in setup.py makes most sense...

Dan Prince (dan-prince)
Changed in python-cinderclient:
assignee: nobody → Dan Prince (dan-prince)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/21434

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/21434
Committed: http://github.com/openstack/python-cinderclient/commit/c5cd7e4862a9ee9bec655cf4aaf96f2d2f67df97
Submitter: Jenkins
Branch: master

commit c5cd7e4862a9ee9bec655cf4aaf96f2d2f67df97
Author: Dan Prince <email address hidden>
Date: Thu Feb 7 11:28:51 2013 -0500

    Re-add setuptools-git to setup.py.

    In 81cbbcc4e01c81084c352f7fc1ecea149089a2b9 we removed:

      setup_requires=['setuptools-git>=0.4'],

    from setup.py. This broke tarball generation in that some files are
    now missing.

    Fixes LP Bug #1118511.

    Change-Id: I27a09e0d49befa3751031582d1b152677822041f

Changed in python-cinderclient:
status: In Progress → Fix Committed
Changed in python-cinderclient:
milestone: none → 1.3.1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.