showing alarm ,deleting alarm and geting alarm state don't need parameter -a/--alarm_id

Bug #1268557 reported by Liusheng
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
Medium
Tom Fifield
python-ceilometerclient
Fix Released
Medium
Nejc Saje

Bug Description

when deleting an alarm, we use "ceilometer alarm-delete -a <ALARM_ID>" ,but I think the parameter -a/--alarm_id is redundant.
like other deleting commands of openstack, with alarm id after "ceilometer alarm-delete" ,It is more easy to use.
Similarly,showing alarm,geting alarm state,showing resource also have the redundant parameter

Liusheng (liusheng)
Changed in python-ceilometerclient:
assignee: nobody → Liusheng (liusheng)
description: updated
Julien Danjou (jdanjou)
Changed in python-ceilometerclient:
status: New → Triaged
importance: Undecided → Medium
Liusheng (liusheng)
summary: - deleting alarm don't need parameter -a/--alarm_id
+ showing alarm and deleting alarm and geting alarm state don't need
+ parameter -a/--alarm_id
summary: - showing alarm and deleting alarm and geting alarm state don't need
+ showing alarm ,deleting alarm and geting alarm state don't need
parameter -a/--alarm_id
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ceilometerclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/66776

Changed in python-ceilometerclient:
status: Triaged → In Progress
Liusheng (liusheng)
Changed in openstack-manuals:
assignee: nobody → Liusheng (liusheng)
Revision history for this message
ZhiQiang Fan (aji-zqfan) wrote :

please note that, for openstack-manuals, it will be affected after that change is released, not only merged, so it may need to wait for the new version of ceilometerclient is released, then it is ok to modify the trunk of openstack-manual.

And, for each OS distribution, their package is different, which means some may follow tightly to upstream (like SUSE havana repo using devstack), or some may very slow to update their repo (like ubuntu)

Lastly, the sad truth is that openstack-manuals is lack of ceilometer support, so this change may not affect it at all (AFAIK), please identify the particular section so we can confirm it.

mark as Incomplete, feel free to open it again. thanks

Changed in openstack-manuals:
status: New → Incomplete
Changed in python-ceilometerclient:
assignee: Liusheng (liusheng) → Nejc Saje (nejc-saje)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ceilometerclient (master)

Reviewed: https://review.openstack.org/66776
Committed: https://git.openstack.org/cgit/openstack/python-ceilometerclient/commit/?id=97e9c254e3e7113bb096be689fa9159293b3920b
Submitter: Jenkins
Branch: master

commit 97e9c254e3e7113bb096be689fa9159293b3920b
Author: ls1175 <email address hidden>
Date: Wed Jan 15 16:31:55 2014 +0800

    Reduce redundant parameter of some commands in CLI

    When deleting an alarm, we use "ceilometer alarm-delete -a <ALARM_ID>",
    unlike other deleting commands of openstack, the parameter-a/--alarm_id
    is redundant. The similar situations exist in showing alarm, geting alarm
    state, showing resource and so on.
    It is more easy to use for reducing these parameters.

    New behaviour:

    $ ceilometer help alarm-show
    usage: ceilometer alarm-show [<ALARM_ID>]

    Show an alarm.

    Positional arguments:
      <ALARM_ID> ID of the alarm to show.

    $ ceilometer alarm-show
    alarm_id should not be empty

    $ ceilometer alarm-show abcde
    Not Found (HTTP 404)

    $ ceilometer alarm-show -a abcde
    -a is obsolete! See help for more details.
    Not Found (HTTP 404)

    $ ceilometer alarm-show --alarm_id abcde
    --alarm_id is obsolete! See help for more details.
    Not Found (HTTP 404)

    Co-Authored-By: Nejc Saje <email address hidden>
    Change-Id: I1fbc85aa253929bfbb5e73ed834a725b9cf828b4
    Closes-bug: #1268557

Changed in python-ceilometerclient:
status: In Progress → Fix Committed
Liusheng (liusheng)
Changed in openstack-manuals:
status: Incomplete → Confirmed
Changed in openstack-manuals:
importance: Undecided → Medium
Revision history for this message
Tom Fifield (fifieldt) wrote :

latest python-ceilometerclient came out after this patch was merged (2014-10-07) so this should be in the manuals now

Revision history for this message
Tom Fifield (fifieldt) wrote :

fixing manual references now

Changed in openstack-manuals:
assignee: Liusheng (liusheng) → Tom Fifield (fifieldt)
milestone: none → kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-manuals (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143836

Changed in openstack-manuals:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/143836
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=9c9de5271c11c2081029a9deaf03ba7c0cb2a866
Submitter: Jenkins
Branch: master

commit 9c9de5271c11c2081029a9deaf03ba7c0cb2a866
Author: Tom Fifield <email address hidden>
Date: Wed Dec 24 22:39:00 2014 +0900

    Fix manual references to old alarm syntax

    The ceilometerclient patch refered to in the bug report
    changed the way ceilometerclient works to not require the
    -a flag for certain alarm commands (history, show etc).

    The CLI reference has already been updated, but this patch
    fixes the remaining manually written commands

    Change-Id: I2e00a6830cd0d4abaa2d37dfb3516bb52f13914b
    Closes-Bug: 1268557

Changed in openstack-manuals:
status: In Progress → Fix Released
Changed in python-ceilometerclient:
milestone: none → 1.3.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-manuals 15.0.0

This issue was fixed in the openstack/openstack-manuals 15.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.