alarm update resets repeat_actions attribute, breaking heat autoscaling

[Eoghan Glynn]

When an unrelated alarm attribute is updated via the CLI, the repeat_actions attribute is also set to False as an unwanted side-effect.

This breaks Heat autoscaling, which sets the repeat_actions to True for any ceilometer alarms it creates because it requires continuous notification as part of its implementation of the scale-up/down policy cooldown logic.

If such an alarm is subsequently modified, .e.g to tune the threshold, then autoscaling actions will no longer occur regardless of the alarm state.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57423

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/57423
Committed: http://github.com/openstack/python-ceilometerclient/commit/7a5cbc14a5ff0679e2797569f9de8ef82068f510
Submitter: Jenkins
Branch: master

commit 7a5cbc14a5ff0679e2797569f9de8ef82068f510
Author: Eoghan Glynn <email address hidden>
Date: Wed Nov 20 09:59:02 2013 +0000

    Avoid reset of repeat_actions attribute on alarm update

    Fixes bug 1253057

    Previously, when an unrelated alarm attribute was updated via the CLI,
    the repeat_actions attribute was also set to False as an unwanted side-effect.

    Now, we only set this attribute in the update call if explicitly specified
    as a CLI arg. Otherwise the value provided in the PUT request body reflects
    the pre-existing value for this attribute.

    Change-Id: I94468ff649dd4367848c74e94a3feb08494bb223