New secret-type argument conflicts with cliff's existing -s/--sort-column flag

Bug #1743578 reported by Colleen Murphy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cliff
Fix Released
High
Dean Troyer
python-barbicanclient
Fix Released
Undecided
Doug Hellmann

Bug Description

On devstack, the barbican CLI is nonfunctional because of a new flag. Here's a traceback: http://paste.openstack.org/show/645732/

The cliff option it's conflicting with is here: http://git.openstack.org/cgit/openstack/cliff/tree/cliff/lister.py?h=2.10.0#n53

The new flag was added in https://review.openstack.org/#/c/486917/

A different short flag should be picked for the --secret-type option.

Revision history for this message
Colleen Murphy (krinkle) wrote :

It's actually cliff that added the new flag in the last few weeks and broke the barbican client: https://review.openstack.org/#/c/521351/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cliff (master)

Fix proposed to branch: master
Review: https://review.openstack.org/534771

Changed in python-cliff:
assignee: nobody → Doug Hellmann (doug-hellmann)
status: New → In Progress
Revision history for this message
Doug Hellmann (doug-hellmann) wrote :

I went ahead and marked barbican client as "fix released" here to close the bug for that project. The bots will close it for cliff when the fix lands in that repo.

Changed in python-cliff:
importance: Undecided → High
Changed in python-barbicanclient:
assignee: nobody → Doug Hellmann (doug-hellmann)
status: New → Fix Released
Revision history for this message
Dave McCowan (dave-mccowan) wrote :

When will this be fixed in python-cliff? This is blocking the gate on merges to barbicanclient, and release date is coming up fast.

Changed in python-cliff:
assignee: Doug Hellmann (doug-hellmann) → Dean Troyer (dtroyer)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cliff (master)

Reviewed: https://review.openstack.org/534771
Committed: https://git.openstack.org/cgit/openstack/cliff/commit/?id=134ebd4a9a5d981f3bccf4f074adc63f1df72f80
Submitter: Zuul
Branch: master

commit 134ebd4a9a5d981f3bccf4f074adc63f1df72f80
Author: Doug Hellmann <email address hidden>
Date: Wed Jan 17 09:22:29 2018 -0500

    remove -s alias for --sort-columns

    Cliff normally uses short option name aliases which are global
    in to the CLI. We want commands to not use them due to the
    limited number and ease of collision. However this one
    was already in use by a well-known plugin so we will not take it.

    Change-Id: Id348dad450b52716b82d7852d6378ecc48808f26
    Closes-Bug: #1743578
    Signed-off-by: Doug Hellmann <email address hidden>

Changed in python-cliff:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cliff 2.11.0

This issue was fixed in the openstack/cliff 2.11.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers