Non-existent style at command line crashes program

[Nathan Haines]

When one specifies a non-existent style on the command-line, for example with './pyroom --style=darkblue', pyroom crashes with a KeyError assertion. Pyroom sets a default style upon startup, and should therefore fall back to the default style if the specified style does not exist.

[Jérôme Guelfucci (jerome-guelfucci-deactivatedaccount)]

Thank you for your bug report. I can confirm the bug, the fix also works correctly. I think it would be a good idea to add on startup in the bottom label that the specified style does not exist and that it picked up the default style, so that people can undestand what happened.

[Nathan Haines (nhaines)]

Thank you for your comment, Jérôme. Indeed, I thought of this but did not persue it.

I have extended PyRoom to allow for a startup message to be appended to the default text, and have updated my branch to reflect this. I like the result and think it is stable, but I am not sure if this is how the feature should be developed. Surely something more robust would be better, but I thought this was the least invasive solution at this time.

[Bruno Bord (brunobord)]

Nathan: your fix has been included in 'code-reorganise' branch. Cheers.

[Nathan Haines (nhaines)]

This has been fixed in the 0.1 release, but hadn't shown up in trunk yet.

[Nathan Haines (nhaines)]

Fix from 0.1 was incorporated into trunk at revision 21 with the merging of Adam Rooke's branch.