| 2015-09-05 00:15:48 |
Chris Macklin |
description |
If break_lock() is called on a LinkLockFile, it cleans up the .lock file but not the unique name. The bug is pretty obvious:
def break_lock(self):
if os.path.exists(self.lock_file):
os.unlink(self.lock_file)
release() calls os.unlink(self.unique_name) in addition to os.unlink(self.lock_file). break_lock() should also call os.unlink(self.unique_name). |
If break_lock() is called on a LinkLockFile, it cleans up the .lock file but not the unique name. The bug is pretty obvious:
def break_lock(self):
if os.path.exists(self.lock_file):
os.unlink(self.lock_file)
release() calls os.unlink(self.unique_name) in addition to os.unlink(self.lock_file). break_lock() should also call os.unlink(self.unique_name).
EDIT: I am an idiot and of course the issue is more complicated than that. If break_lock is called, then the unique_name link is that of the process that is already locking, not the process that it is being unlocked from. I'm not really sure what to do about this, but it is a pretty frustrating issue. break_lock is a useful interprocess signal, but it leaves the directory the locked file is in strewn with stale unique_name links. |
|
