PyPI package should depend on pydns

[Peter Mattern]

pyLibravatar currently depends on py3dns and pydns to work under Python 3 and Python 2 respectively but PyPI package pyLibravatar does not depend on these.
It would be good if this dependency was fixed.

[François Marier (fmarier)]

The dependency is in there: https://git.launchpad.net/pylibravatar/tree/setup.py#n4

Is that not the correct way to do it for PyPI?

[Peter Mattern (pmattern)]

Unfortunately I cannot really judge this, so all I can do is report my findings.
And these are 'pip[N] install pylibravatar' does not pull py[3]dns running the pip implementations belonging to Python 3 or 2 on either Arch Linux or Debian stretch. And so far I haven't seen any such problem with any other PyPI package on those platform which is suggesting the problem is in pyLibravatar, IMHO.

[Launchpad Janitor (janitor)]

[Expired for pyLibravatar because there has been no activity for 60 days.]

[François Marier (fmarier)]

A requirements.txt file is probably what's missing here:

https://pip.readthedocs.io/en/1.1/requirements.html
http://codeinthehole.com/tips/using-pip-and-requirementstxt-to-install-from-the-head-of-a-github-branch/

[François Marier (fmarier)]

Another article on the difference between setup.py and requirements.txt: https://caremad.io/posts/2013/07/setup-vs-requirement/

[frenzy (frenzy-madness)]

Hello.

I also have some troubles because of this bug.

Actually, it doesn't matter if you define your dependencies in setup.py directly or you will read them from requirements file. The important part is to define all dependencies which should be installed together with pylibravatar in setup.py with install_requires.

As you can see in setuptools docs [0], requires kwarg is only for metadata and it doesn't make setuptools to do anything different. What you need to specify is install_requires kwarg as mentioned in the docs as well [1].

So, to fix this problem, change `requires = requires,` to `install_requires = requires,` in setup.py on line 19.

Could you please try this fix and release a new version? Let me know if I can help you with anything.

Thank you and have a nice day.

[0] https://setuptools.readthedocs.io/en/latest/setuptools.html#metadata
[1] https://setuptools.readthedocs.io/en/latest/setuptools.html#new-and-changed-setup-keywords
[2] https://git.launchpad.net/pylibravatar/tree/setup.py