pyjuju

Remove 'default-instance-type' from environments file.

  1. Series 0.5
  2. Bug #1069883
Bug #1069883 reported by Andrew Glen-Young
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
pyjuju
Fix Released
Medium
Martin Packman
pyjuju 0.7 "ibiza"
0.5
Fix Released
Medium
Martin Packman
pyjuju 0.5.3
0.6
Fix Released
Medium
Martin Packman
pyjuju 0.6.1

Bug Description

Juju requires that the 'default-instance-type' in the environments.yaml file exist, but it is unused (at least for the openstack provider). If the variable is no longer needed, juju should emit a deprecation warning and not launch the instance.

It is confusing to a user as setting default-instance-type=m1.small and launching an instance results in a m1.tiny instance being launched.

Setting the instance type using constraints on launch works as expected.

Juju version: 0.6.0.1+bzr598
Ubuntu version: 12.04.1

Related branches

lp:~gz/pyjuju/no_default_instance_1069883
Juju Engineering: Pending requested
Diff: 145 lines (+33/-6)
5 files modified
juju/environment/config.py (+3/-2)
juju/environment/tests/test_config.py (+0/-1)
juju/providers/openstack/launch.py (+1/-1)
juju/providers/openstack/tests/__init__.py (+0/-2)
juju/providers/openstack/tests/test_launch.py (+29/-0)
lp:~gz/pyjuju/0.6_default_instance_backport
Martin Packman (community): Approve
Diff: 136 lines (+32/-6)
5 files modified
juju/environment/config.py (+3/-2)
juju/environment/tests/test_config.py (+0/-1)
juju/providers/openstack/launch.py (+1/-1)
juju/providers/openstack/tests/__init__.py (+0/-2)
juju/providers/openstack/tests/test_launch.py (+28/-0)
lp:~gz/pyjuju/0.5_default_instance_backport
Martin Packman (community): Approve
Diff: 136 lines (+32/-6)
5 files modified
juju/environment/config.py (+3/-2)
juju/environment/tests/test_config.py (+0/-1)
juju/providers/openstack/launch.py (+1/-1)
juju/providers/openstack/tests/__init__.py (+0/-2)
juju/providers/openstack/tests/test_launch.py (+28/-0)
Haw Loeung (hloeung)
tags: added: canonical-webops-juju
Revision history for this message
Martin Packman (gz) wrote :

There is already a warning in the code, but the condition is backwards, so it's emitted if default-instance-type is *not* defined... which is never the case as the config doesn't treat it as optional. Additionally the value is ignored in favour if the default constraints in all cases.

Changed in juju:
importance: Undecided → Medium
status: New → Confirmed
Martin Packman (gz)
Changed in juju:
assignee: nobody → Martin Packman (gz)
milestone: none → 0.7
status: Confirmed → In Progress
Martin Packman (gz)
Changed in juju:
status: In Progress → Fix Committed
Martin Packman (gz)
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.