Must complain if charm hooks aren't executable

Bug #864164 reported by Gustavo Niemeyer
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
juju-core
Medium
Dimiter Naydenov
pyjuju
Low
Unassigned

Bug Description

Juju is bundling charms that will knowingly break because the executable flag in the charm are not set.

It should either fix the flags by itself, or at least refuse to go ahead.

Related branches

Changed in juju:
assignee: nobody → Gustavo Niemeyer (niemeyer)
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

People are dropping random bits in the hook directory, so the hook validation routines used by debug-hooks is probably the best for the enumeration and executable check.

Changed in juju:
milestone: none → florence
Changed in juju:
status: New → Triaged
importance: Undecided → Medium
Changed in juju:
assignee: Gustavo Niemeyer (niemeyer) → nobody
Changed in juju:
milestone: florence → galapagos
Changed in juju:
milestone: galapagos → honolulu
Changed in juju:
milestone: 0.6 → none
Martin Packman (gz)
Changed in juju-core:
assignee: nobody → Dave Cheney (dave-cheney)
importance: Undecided → Medium
Changed in juju-core:
milestone: none → 1.9.4
Revision history for this message
Kapil Thangavelu (hazmat) wrote : Re: [Bug 864164] Re: Must complain if charm hooks aren't executable

i believe core just makes them executable when bundling.

On Tue, Dec 4, 2012 at 10:30 PM, Dave Cheney <email address hidden>wrote:

> ** Changed in: juju-core
> Milestone: None => 1.9.4
>
> --
> You received this bug notification because you are subscribed to juju.
> https://bugs.launchpad.net/bugs/864164
>
> Title:
> Must complain if charm hooks aren't executable
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju/+bug/864164/+subscriptions
>

Changed in juju-core:
milestone: 1.9.4 → 1.9.5
Changed in juju-core:
milestone: 1.9.5 → 1.9.6
Changed in juju-core:
assignee: Dave Cheney (dave-cheney) → nobody
milestone: 1.9.6 → none
status: New → Triaged
Changed in juju-core:
assignee: nobody → Dimiter Naydenov (dimitern)
status: Triaged → In Progress
Revision history for this message
Dimiter Naydenov (dimitern) wrote :

No, actually juju-core does not make hooks executable neither when bundling, nor when expanding a bundle. It'll now, once my fix lands.

Changed in juju-core:
milestone: none → 2.0
Revision history for this message
Dimiter Naydenov (dimitern) wrote :

Fixed in juju-core trunk.

Changed in juju-core:
status: In Progress → Fix Committed
Changed in juju-core:
milestone: 2.0 → 1.9.12
Changed in juju-core:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in juju:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers