pyjuju

removed charm components are not cleaned up when upgrading

Bug #791035 reported by Clint Byrum
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pyjuju
Fix Released
Medium
Kapil Thangavelu

Bug Description

I recently removed a hook from a formula and then used upgrade-formula. To my surprise, the removed hook was still there and being executed, along side the new code.

Related branches

lp:~hazmat/pyjuju/formula-upgrade-removes-obsolete
On hold for merging into lp:pyjuju
Gustavo Niemeyer: Needs Information
Diff: 295 lines (+141/-9)
9 files modified
ensemble/agents/tests/test_unit.py (+50/-4)
ensemble/agents/unit.py (+19/-3)
ensemble/formula/base.py (+7/-0)
ensemble/formula/bundle.py (+7/-0)
ensemble/formula/directory.py (+21/-1)
ensemble/formula/tests/test_base.py (+4/-0)
ensemble/formula/tests/test_bundle.py (+7/-0)
ensemble/formula/tests/test_directory.py (+17/-1)
ensemble/unit/tests/test_lifecycle.py (+9/-0)
Kapil Thangavelu (hazmat)
Changed in ensemble:
milestone: none → dublin
importance: Undecided → Medium
Kapil Thangavelu (hazmat)
Changed in ensemble:
status: New → In Progress
assignee: nobody → Kapil Thangavelu (hazmat)
Kapil Thangavelu (hazmat)
Changed in ensemble:
status: In Progress → Confirmed
Kapil Thangavelu (hazmat)
Changed in ensemble:
milestone: dublin → eureka
Clint Byrum (clint-fewbar)
summary: - removed formula components are not cleaned up when upgrading
+ removed charm components are not cleaned up when upgrading
Kapil Thangavelu (hazmat)
Changed in juju:
milestone: eureka → florence
Kapil Thangavelu (hazmat)
Changed in juju:
milestone: florence → eureka
Kapil Thangavelu (hazmat)
Changed in juju:
milestone: eureka → florence
Revision history for this message
William Reade (fwereade) wrote :

Note that we can't just delete the charm and overwrite it -- some charms store state within themselves.

Kapil Thangavelu (hazmat)
Changed in juju:
milestone: florence → galapagos
Clint Byrum (clint-fewbar)
Changed in juju:
milestone: galapagos → honolulu
Clint Byrum (clint-fewbar)
Changed in juju:
milestone: 0.6 → none
Curtis Hovey (sinzui)
Changed in juju:
status: Confirmed → Triaged
Revision history for this message
Kapil Thangavelu (hazmat) wrote : Re: [Bug 791035] Re: removed charm components are not cleaned up when upgrading

fixed in juju-core (internally it uses git).

On Fri, Oct 11, 2013 at 11:42 PM, Curtis Hovey <email address hidden> wrote:

> ** Changed in: juju
> Status: Confirmed => Triaged
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/791035
>
> Title:
> removed charm components are not cleaned up when upgrading
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju/+bug/791035/+subscriptions
>

Changed in juju:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.