2.1.0 Build failure on Solaris

Bug #518871 reported by dns
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Python-Crypto
Fix Released
Wishlist
Unassigned

Bug Description

The files _counter.h, Blowfish.c and RIPEMD160.c include stdint.h. This is not available on Solaris 9 and earlier; although inttypes.h appears to be equivalent.

Revision history for this message
Darsey Litzenberger (dlitz) wrote :

stdint.h is part of the C99 standard, and provides specific-width types like uint8_t and uint64_t. I don't have Solaris 9 or earlier, so if you want this fixed, I'll need a patch.

Changed in pycrypto:
status: New → Incomplete
importance: Undecided → Wishlist
Revision history for this message
Sebastian Kayser (skayser) wrote :

Dwayne, we are currently packaging pycrypto for Solaris via opencsw.org. The following patch addresses this inclusion issue on Solaris (conditionally includes sys/inttypes.h instead of stdint.h). Other platforms remain unaffected.

  http://gar.svn.sf.net/svnroot/gar/csw/mgar/pkg/lang-python/pycrypto/trunk/files/0001-On-Solaris-Use-sys-inttypes.h-instead-of-stdint.h.patch

Also, in case you could use Solaris platform access, we provide access to our Solaris build environment (Solaris 8/9/10, x86/SPARC) for upstream open source maintainers. Feel free to give us a shout. http://www.opencsw.org/extend-it/signup/to-upstream-maintainers/

Revision history for this message
Darsey Litzenberger (dlitz) wrote :

Thanks!

I've fixed this in a slightly different way (I prefer to include stdint.h on any system that supports it, and since we now use autoconf, that's pretty straightforward).

https://github.com/dlitz/pycrypto/commit/7401e648d44f9324a313346f45e86fc5e779a7aa

Please let me know if that works for you.

Changed in pycrypto:
status: Incomplete → Fix Committed
Revision history for this message
Darsey Litzenberger (dlitz) wrote :

Released in PyCrypto 2.4.

Changed in pycrypto:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.