Python GIL isn't reacquired when error is encountered
Bug #452195 reported by
lorenz quack
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Python-Crypto |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
This may not be considered a bug but I though I report it anyway.
In "ALG_Encrypt()" and "ALG_Decrypt()" there is a "switch(mode)" after releasing the GIL.
In the "default" section of those switches the GIL isn't reacquired but calls to Python are made specifically "PyErr_Format()".
The "default" section is only entered when there is an error in the internal state (unknown mode) but still I think the GIL should be reacquired.
A patch is appended.
Revision history for this message
| lorenz quack (lorenz.quack) wrote | #1 |
Revision history for this message
| Darsey Litzenberger (dlitz) wrote | #2 |
| Changed in pycrypto: | |
| status: | New → Fix Released |
| Changed in pycrypto: | |
| milestone: | none → 2.1.0 |
To post a comment you must log in.
Agreed. If we're going to bother handling the default case at all, we should at least do it properly.
Fix committed:
http://