Add support for Camellia block cipher
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Python-Crypto |
Confirmed
|
Wishlist
|
Unassigned |
Bug Description
I would like to post a patch to add support for Camellia block cipher to pycrypto. Camellia is one of the selected block cipher by New European Schemes for Signature, Integrity, and Encryption (NESSIE) and specified in several RFCs. It is also included in some open source softwares, such as FreeBSD, Linux, OpenSSL, Firefox 3, GnuPG and so on. You can get detailed
information for Camellia from:
http://
Will you review and test it?
I hope my patch will be imported into pycrypto.
Note that I have also posted the same bug report to:
http://
Since I thought the bug tracking system above has not been working, I will also post the same patch to this bug tracking system.
Thank you in advance.
Changed in pycrypto: | |
importance: | Undecided → Wishlist |
status: | New → Confirmed |
Changed in pycrypto: | |
milestone: | none → 2.2 |
Changed in pycrypto: | |
milestone: | 2.2 → none |
Thank you for your patch!
The goals for the next release are:
- to fix bugs
- to deal with potential copyright issues, and
- to fix long-standing problems with how people generate random numbers for use with PyCrypto.
The resulting set of changes is already fairly large, and I don't want to make it larger by adding new ciphers, so Camellia will probably not be included in the next release. I will consider it for future releases, however.
Looking at your patch, I noticed that you have included copyright licensing statements in camellia.c and camellia.h, but the author's name and copyright licensing for the PyCrypto-specific parts of the patch are missing. The ideal situation would be for the PyCrypto-specific contributions to be placed into the public domain (i.e. all copyright interests be disclaimed). Alternatively, the same license that the Camellia reference implementation uses (i.e. 2-clause BSD) would be fine.