src/hash_SHA2_template.c:97: bad if test ?

[dcb]

Static analyser cppcheck says many things about pycrypto-2.6.1,
including

[src/hash_SHA2_template.c:97]: (style) Same expression on both sides of '>'.

Source code is

        if (hs->length_upper > hs->length_upper)
            return 0;

I checked the latest source code in github and it looks broken there also.

[Legrandin (gooksankoo)]

That is harmless dead code that should be removed.

It purely influences the return value of the function add_length(), but such value is ignored by all of its callers anyway.

[Richard Mitchell (mitchellrj)]

See https://github.com/dlitz/pycrypto/pull/78