Python-Crypto

except without exception type

Bug #1178485 reported by Sebastian Ramacher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Python-Crypto
Fix Committed
Undecided
Unassigned

Bug Description

We have several cases of excepts without an exception type. This is bad since this will also catch KeyboardInterrupt and SystemExit. See for more details http://docs.python.org/2/howto/doanddont.html#except.

The following parts of PyCrypto have such excepts:

lib/Crypto/SelfTest/Signature/test_pkcs1_15.py:167
lib/Crypto/SelfTest/Signature/test_pkcs1_15.py:188
lib/Crypto/Util/asn1.py:210
lib/Crypto/Util/asn1.py:207
lib/Crypto/Util/py3compat.py:78

Revision history for this message
Richard Mitchell (mitchellrj) wrote :

asn1 fixed in https://github.com/dlitz/pycrypto/commit/5a0ee14e9904335cb90c0dd7a4e10f1523435c52#diff-6ea06840fa0ebc1756e19946e65bbc12

The rest in this pull request: https://github.com/dlitz/pycrypto/pull/82

Revision history for this message
Darsey Litzenberger (dlitz) wrote :

Applied: https://github.com/dlitz/pycrypto/commit/9e171b794f102f5745076051202997df9eac254a
Fixed: https://github.com/dlitz/pycrypto/commit/f070adf984c6bb3ef72a3bf3d05648ea304eaa61

Thanks!

Changed in pycrypto:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.