vs_bridge: external ids are not updated when keys exist

[Takashi Kajinami]

It seems vs_bridge does not update the existing external ids if keys already exist.

[root@localhost ~]# ovs-vsctl br-get-external-id testbr
a=c
[root@localhost ~]# cat bridge.pp
vs_bridge { 'testbr':
  external_ids => 'a=b,b=c'
}
[root@localhost ~]# sudo puppet apply --modulepath /usr/share/openstack-puppet/modules/ bridge.pp
Notice: Compiled catalog for localhost.localdomain in environment production in 0.01 seconds
Notice: /Stage[main]/Main/Vs_bridge[testbr]/external_ids: external_ids changed 'a=c' to 'a=b,b=c'
Notice: Applied catalog in 0.04 seconds
[root@localhost ~]# ovs-vsctl br-get-external-id testbr
a=c
b=c

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-vswitch/+/901391

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-vswitch/+/901391
Committed: https://opendev.org/openstack/puppet-vswitch/commit/0f8e830a093bfc35c1341fc5f6efc97f97992e4e
Submitter: "Zuul (22348)"
Branch: master

commit 0f8e830a093bfc35c1341fc5f6efc97f97992e4e
Author: Takashi Kajinami <email address hidden>
Date: Sun Nov 19 17:04:11 2023 +0900

    vs_bridge: Ensure existing external ids are updated

    ... and also the ids not included by the given list are purged.

    Closes-Bug: #2043916
    Change-Id: I058614b9113edd6e65238b924e5f474cab37946e

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/puppet-vswitch/+/901489

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-vswitch/+/901518

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-vswitch/+/901489
Committed: https://opendev.org/openstack/puppet-vswitch/commit/c3764491cf6f422cbb5e360ee8b3e220f411d69e
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit c3764491cf6f422cbb5e360ee8b3e220f411d69e
Author: Takashi Kajinami <email address hidden>
Date: Sun Nov 19 17:04:11 2023 +0900

    vs_bridge: Ensure existing external ids are updated

    ... and also the ids not included by the given list are purged.

    Closes-Bug: #2043916
    Change-Id: I058614b9113edd6e65238b924e5f474cab37946e
    (cherry picked from commit 0f8e830a093bfc35c1341fc5f6efc97f97992e4e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-vswitch/+/901518
Committed: https://opendev.org/openstack/puppet-vswitch/commit/808e3104a25fbd378cab681a42f586b96fafd779
Submitter: "Zuul (22348)"
Branch: master

commit 808e3104a25fbd378cab681a42f586b96fafd779
Author: Takashi Kajinami <email address hidden>
Date: Tue Nov 21 13:09:37 2023 +0900

    Add unit test cases for bug 2043916

    This is follow-up of 0f8e830a093bfc35c1341fc5f6efc97f97992e4e and
    add the unit test cases to detect any regression.

    Related-Bug: #2043916
    Change-Id: I8a4b2bf1ca839f5b8c98000212c313498257460b

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/puppet-vswitch/+/901845

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-vswitch/+/901845
Committed: https://opendev.org/openstack/puppet-vswitch/commit/a29253556818049c103cb4f4f41d893c64cd6e98
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit a29253556818049c103cb4f4f41d893c64cd6e98
Author: Takashi Kajinami <email address hidden>
Date: Sun Nov 19 17:04:11 2023 +0900

    vs_bridge: Ensure existing external ids are updated

    ... and also the ids not included by the given list are purged.

    Closes-Bug: #2043916
    Change-Id: I058614b9113edd6e65238b924e5f474cab37946e
    (cherry picked from commit 0f8e830a093bfc35c1341fc5f6efc97f97992e4e)
    (cherry picked from commit c3764491cf6f422cbb5e360ee8b3e220f411d69e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-vswitch 20.0.0 release.