other_config:vlan-limit is not purged by default

[Takashi Kajinami]

Currently the vswitch::ovs class does not remove the vlan-limit option by default. Because of this, if a user once set the option and remove it later, the option is left unmanaged in openvswitch.

This is caused by the behavior of puppet and it does not sync the property when a nil value(undef) is passed.
 https://github.com/puppetlabs/puppet/commit/67e1bba154accd900b9690d96cec8b050f8082e7

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-vswitch/+/851283

[Takashi Kajinami (kajinamit)]

This was not actually a regression. We expected the change in yoga allows users to purge the config by default but that was not true.

While implementing this, I noticed that ovn-controller sets "0" automatically if the parameter is not set, and that is causing broken idempotency.

I'll give it another thought to find out any good way to handle this but I might just close this as WON'T FIX if I don't come up with any good solutions.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Takashi Kajinami <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/puppet-vswitch/+/851283