Log file for guestagent is /var/log/trove/trove-taskmanager.log instead of .../trove-guestagent.log

[Luigi Toscano]

As the topic says, the generated configuration file /etc/trove/trove-guestagent.conf contains:

log_file = /var/log/trove/trove-taskmanager.log

instead of
log_file = /var/log/trove/trove-guestagent.log

even if trove-guestagent.log is set into trove::guestagent class.

I suspect this is related to the way trove-guestagent.conf is created (template call inside the trove::taskmanager class, so excluding trove::guestagent), but my Puppet skills are quite low.

Found on version 6.0.0 (testing RDO Liberty, packstack installation)

[shravya Gaddam (shravya-g90)]

Hi

In /etc/trove/trove-guestagent.conf
The log file shows
log_file = logfile.txt
but not log_file = /var/log/trove/trove-taskmanager.log.

Can you please suggest me on this

Thanks

[Luigi Toscano (ltoscano)]

I don't see any reference to logfile.txt into the puppet-trove repository. What are you looking to exactly?

[shravya Gaddam (shravya-g90)]

The file /etc/trove/trove-guestagent.conf is present in TROVE but not Puppet-Trove.
Please clarify me on this.

Thanks

[Luigi Toscano (ltoscano)]

Yes, it is the point. puppet-trove contains puppet modules used to generate the configuration files; see the README.md file in the base directory of puppet-trove. So it does not contain that file, it can generate it when used in some puppet script.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/241884

[shravya Gaddam (shravya-g90)]

By changing the values of

 if $guestagent_config_file {
    if $use_guestagent_template {
      file { $guestagent_config_file:
        content => template('trove/trove-guestagent.conf.erb')
      }
    } else {
      class {'::trove::guestagent':
        enabled => false, -----to TRUE
        manage_service => false,------- to TRUE
      }
    }

Can you please suggest me will this impact the change .

Thanks in advance!

[Shaik Apsar (sa709c)]

The issue is related to the trove-guestagent.conf.erb file.

# Directory and path for log files
log_dir = <%= @log_dir %>
log_file = <%= @log_file %>

By default use_guestagent_template is set to true in taskmanager.pp and it will update the trove-guestagent.conf content with the log_file param of the taskmanager.pp.

[Shaik Apsar (sa709c)]

I think you can hardcode the log_file value in trove-guestagent.conf.erb since it is used only when use_guestagent_template is enabled in taskmanager.pp.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/321154

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/321154
Committed: https://git.openstack.org/cgit/openstack/puppet-trove/commit/?id=d24a11c35d3cfa522cea7e7aa441554816ebe205
Submitter: Jenkins
Branch: master

commit d24a11c35d3cfa522cea7e7aa441554816ebe205
Author: Shaik Apsar <email address hidden>
Date: Wed May 25 14:04:16 2016 -0400

    Option to specify the trove guestagent log file.

    Change-Id: Ifaf124933bca6b64d6a2d5225a5f67e58058e26f
    Closes-Bug: #1506835

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-trove 9.1.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/241884
Reason: Abandoning per our policy[0]. If you wish to continue this work, please restore this or let us know in #puppet-openstack and we can restore it.

[0] https://docs.openstack.org/developer/puppet-openstack-guide/reviews.html