Non-hiera users can not override guestagent params when not using template config in taskmanager

[Xingchao Yu]

In trove::taskmanager, we use guestagent_config_file option and template to control whether to manage injected guest agent configuration or not.

1. trove-guestagent.conf.erb has option typo problem, which will lead guestagent fails to run.
2. template is out of date to master upstream.
3. trove::guestagent could do this thing better.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/215476

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/215476
Committed: https://git.openstack.org/cgit/openstack/puppet-trove/commit/?id=cdf452769e0da7944c51ca422898911de753a3cc
Submitter: Jenkins
Branch: master

commit cdf452769e0da7944c51ca422898911de753a3cc
Author: Xingchao Yu <email address hidden>
Date: Fri Aug 21 14:08:04 2015 +0800

    Introduce use_guestagent_template option

    Current, trove::taskmanager use template to generate guestagent
    configuration file.

    This patch is aim to do following efforts:
      1. Fix template file option typo error
      2. Update template to keep up with master branch of
         guestagent.conf.sample
      3. Add use_guestagent_template option to give more choice for
         people who want use trove::guestagent to manage guestagent.conf.
         To keep compatibility, default value is set to true

    Close-Bug: #1485397
    Change-Id: I74cba2ad10a811f91ab65f004de78c93309fc95a

[Emilien Macchi (emilienm)]

Your (merged) patch is actually not correct.
The else disallow to run Trove guest agent on the same node as taskmanager.

[Emilien Macchi (emilienm)]

So the patch merged [1] injected a new bug:
if you don't use the template, the manifest will import trove::guestagent. So people who don't use Hiera won't be able to override parameters in the guestagent.pp.

[1] https://github.com/openstack/puppet-trove/commit/cdf452769e0da7944c51ca422898911de753a3cc

[Xingchao Yu (yuxcer)]

As we have discussed on IRC, we will abandon template with a deprecation warning and make guestagent parameters configurable.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-trove/+/834096

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-trove/+/834096
Committed: https://opendev.org/openstack/puppet-trove/commit/4c6e5c9d76e142b3544a3eed07dcea5a2b75537a
Submitter: "Zuul (22348)"
Branch: master

commit 4c6e5c9d76e142b3544a3eed07dcea5a2b75537a
Author: Takashi Kajinami <email address hidden>
Date: Thu Mar 17 13:27:53 2022 +0900

    Disable trove-guestagent service by default

    The trove-guestagent service should be run in instances instead of
    OpenStack hosts. This change disables the service by default because
    we expect these modules are used to deploy hosts, and we don't expect
    any use case where this puppet module is used to build the trove guest
    image.

    Closes-Bug: #1965228
    Closes-Bug: #1485397
    Change-Id: I57aa6ecd008f1a7a271e7baafc95cd75bf700f54

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-trove 20.3.0 release.