Unable to setup pids-limit for galera pcs resource via heat templates

[Antonio Romito]

Description
===========
Currently is it not possible to set --pids-limit for galera pcs resource via heat template

Steps to reproduce
==================
It can be only manually set file limits by adding --pids-limits to pacemaker cib but this requires manual steps.

~~~
Commands to be run:
# Do this on any cluster node
# Unmanaged the resource
pcs resource unmanage galera-bundle

# Dump the original CIB
pcs cluster cib > cib-galera.xml
cp cib-galera.xml cib-galera.xml.org
# Edit cib-galera.xml and update on the resource so that the galera-bundle line looks like the following (choose the limit you want):
#
# - <podman image="cluster.common.tag/rhosp16-openstack-mariadb:pcmklatest" network="host" options="--user=root --log-driver=k8s-file --log-opt path=/var/log/containers/stdouts/galera-bundle.log -e KOLLA_CONFIG_STRATEGY=COPY_ALWAYS" promoted-max="3" replicas="3" run-command="/bin/bash /usr/local/bin/kolla_start"/>
# + <podman image="cluster.common.tag/rhosp16-openstack-mariadb:pcmklatest" network="host" options="--user=root --pids-limit 6666 --log-driver=k8s-file --log-opt path=/var/log/containers/stdouts/galera-bundle.log -e KOLLA_CONFIG_STRATEGY=COPY_ALWAYS" promoted-max="3" replicas="3" run-command="/bin/bash /usr/local/bin/kolla_start"/>

# Push the updated CIB. At this stage, no galera resource will restart
pcs cluster cib-push --config cib-galera.xml

# Force pacemaker to reprobe the state of the galera resource (that way it forgets that it has to restart it once it becomes managed again)
pcs resource refresh galera-bundle

# Give back control of the resource to pacemaker
pcs resource manage galera-bundle

# restart each resource individually for a rolling restart and the new value to take effect
~~~

Expected result
===============
--pid-limit should be tunable manually via heat template

Actual result
=============
Currently, it's only possible to set it by modifying manually galera's CIB.

Environment
===========
OpenStack Train

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/849629
Committed: https://opendev.org/openstack/puppet-tripleo/commit/91eb4140b5b8337cbd029a58ea1cb4c3bab3fa21
Submitter: "Zuul (22348)"
Branch: master

commit 91eb4140b5b8337cbd029a58ea1cb4c3bab3fa21
Author: Antonio Romito <email address hidden>
Date: Thu Nov 24 09:06:30 2022 +0000

    Template option addition for --pids-limit on Galera cluster resource

    mysql_bundle.pp has been modified to be able to configure --pids-limit option
    using a template. By default the parameter remains 'undef' when not specified.
    When "tripleo::profile::pacemaker::database::mysql_bundle::pids_limit:" is used
    as an ExtraConfig it will automatically set the value in the Galera cluster
    resource.

    Closes-Bug: #1982751

    Change-Id: Iffe9c9a1d7ca736f273d2da43928d7da4a99d1d6

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 18.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/882512

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Ghanshyam <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/882512
Reason: TrieplO project is retiring now, for details, please see https://review.opendev.org/c/openstack/governance/+/905145 or reach out to OpenStack TC.