Deployment should fail if ComputeInstanceHA nodes don't have required stonith resources

[Luca Miccini]

summary says it all. ComputeInstanceHA nodes need proper fencing devices or vms disks could get corrupted. Deployment should fail if there isn't at least one valid device per node.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/820177

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/820177
Committed: https://opendev.org/openstack/puppet-tripleo/commit/a4fa4fbb76acdb8363bcedb14ec9cf6a11626b36
Submitter: "Zuul (22348)"
Branch: master

commit a4fa4fbb76acdb8363bcedb14ec9cf6a11626b36
Author: Luca Miccini <email address hidden>
Date: Thu Dec 2 15:20:09 2021 +0100

    Enforce stonith for ComputeInstanceHA nodes

    With the implementation of stonith levels support via bacfec8647 we
    accidentally lifted the requirement for ComputeInstanceHA nodes to
    have at least one valid stonith device.

    This commit re-introduces a check to make sure there is at least
    one valid fencing agent configured, computing the total number of
    stonith resources belonging to each node and making sure to raise
    an exception if this value is zero.

    This check is performed only for the first level so to allow
    different stonith topologies per node (eg controller nodes can
    have two levels, while computes only one) and still account for
    the missing devices.

    Closes Bug: #1953042

    Change-Id: I5ca68bcc2cfe34f2e95758628155e4f5b872305a

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/822425

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/822425
Committed: https://opendev.org/openstack/puppet-tripleo/commit/fcfebe419c2b4b7c948ca00727912f23a08a9638
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit fcfebe419c2b4b7c948ca00727912f23a08a9638
Author: Luca Miccini <email address hidden>
Date: Thu Dec 2 15:20:09 2021 +0100

    Enforce stonith for ComputeInstanceHA nodes

    With the implementation of stonith levels support via bacfec8647 we
    accidentally lifted the requirement for ComputeInstanceHA nodes to
    have at least one valid stonith device.

    This commit re-introduces a check to make sure there is at least
    one valid fencing agent configured, computing the total number of
    stonith resources belonging to each node and making sure to raise
    an exception if this value is zero.

    This check is performed only for the first level so to allow
    different stonith topologies per node (eg controller nodes can
    have two levels, while computes only one) and still account for
    the missing devices.

    Closes Bug: #1953042

    Change-Id: I5ca68bcc2cfe34f2e95758628155e4f5b872305a
    (cherry picked from commit a4fa4fbb76acdb8363bcedb14ec9cf6a11626b36)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 16.1.0 release.