tripleo

puppet-rsync could not enable rsyncd

Bug #1945962 reported by Michele Baldessari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Michele Baldessari
tripleo xena-3

Bug Description

I see the following on centos stream 9:

2021-10-04T08:43:54.480629255+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/bin/true'
2021-10-04T08:43:54.486557677+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/usr/bin/systemctl is-enabled -- rsyncd'
2021-10-04T08:43:54.495188022+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/usr/bin/systemctl unmask -- rsyncd'
2021-10-04T08:43:54.502673716+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/usr/bin/systemctl enable -- rsyncd'
2021-10-04T08:43:54.511733823+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Error: Could not enable rsyncd:
2021-10-04T08:43:54.513360119+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Error: /Stage[main]/Rsync::Server/Service[rsyncd]/enable: change from 'false' to 'true' failed: Could not enable rsyncd:
2021-10-04T08:43:54.513669485+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/bin/true'

Potentially this one made the issue start: https://github.com/puppetlabs/puppetlabs-rsync/commit/ea6397ef55273b7e20d8eccece493cceb795f5eb

Seems the problem is in the tags and/or the missing noop for the rsync server though. Tags are :
--tags "file,file_line,concat,augeas,cron,swift_config,swift_proxy_config,swift_keymaster_config,swift_config,swift_container_config,swift_container_sync_realms_config,swift_account_config,swift_object_config,swift_object_expirer_config,rsync::server"

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/812307

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-tripleo (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/812338

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-tripleo (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/812338
Committed: https://opendev.org/openstack/puppet-tripleo/commit/8e6e49d28d4db79745371f737a16731f2faad00b
Submitter: "Zuul (22348)"
Branch: master

commit 8e6e49d28d4db79745371f737a16731f2faad00b
Author: Michele Baldessari <email address hidden>
Date: Mon Oct 4 12:34:21 2021 +0200

    Add ability to noop a service

    We want also be able to noop_resource('service'). In order to do that we
    also add stubs for status, start and stop. Without this it fails with:
    [root@controller-0 openstack-puppet]# NET_HOST=true DEBUG=True PROCESS_COUNT=1 CONFIG=/root/bandini.json python3 /var/lib/container-puppet/container-puppet.py 2>&1 | tee /tmp/puppet.log |grep Error:
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Could not evaluate: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Failed to call refresh: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Could not evaluate: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Failed to call refresh: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    [root@controller-0 openstack-puppet]# NET_HOST=true DEBUG=True PROCESS_COUNT=1 CONFIG=/root/bandini.json python3 /var/lib/container-puppet/container-puppet.py 2>&1 | tee /tmp/puppet.log |grep Error:
    <13>Oct 4 10:29:03 puppet-user: Error: Could not set 'running' on ensure: undefined method `start' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:29:03 puppet-user: Error: Could not set 'running' on ensure: undefined method `start' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop

    Related-Bug: #1945962

    Change-Id: I9ee8108fe749e787b82f8f4c226f44685ab21a99

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-tripleo (stable/wallaby)

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/812389

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-tripleo (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/812389
Committed: https://opendev.org/openstack/puppet-tripleo/commit/04d8b5836152e5d1da6f56f90e16679fe931b6c4
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 04d8b5836152e5d1da6f56f90e16679fe931b6c4
Author: Michele Baldessari <email address hidden>
Date: Mon Oct 4 12:34:21 2021 +0200

    Add ability to noop a service

    We want also be able to noop_resource('service'). In order to do that we
    also add stubs for status, start and stop. Without this it fails with:
    [root@controller-0 openstack-puppet]# NET_HOST=true DEBUG=True PROCESS_COUNT=1 CONFIG=/root/bandini.json python3 /var/lib/container-puppet/container-puppet.py 2>&1 | tee /tmp/puppet.log |grep Error:
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Could not evaluate: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Failed to call refresh: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Could not evaluate: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: Failed to call refresh: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:28:26 puppet-user: Error: /Service[rsyncd]: undefined method `status' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    [root@controller-0 openstack-puppet]# NET_HOST=true DEBUG=True PROCESS_COUNT=1 CONFIG=/root/bandini.json python3 /var/lib/container-puppet/container-puppet.py 2>&1 | tee /tmp/puppet.log |grep Error:
    <13>Oct 4 10:29:03 puppet-user: Error: Could not set 'running' on ensure: undefined method `start' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop
    <13>Oct 4 10:29:03 puppet-user: Error: Could not set 'running' on ensure: undefined method `start' for Service[rsyncd](provider=noop):Puppet::Type::Service::ProviderNoop

    Related-Bug: #1945962

    Change-Id: I9ee8108fe749e787b82f8f4c226f44685ab21a99
    (cherry picked from commit 8e6e49d28d4db79745371f737a16731f2faad00b)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/812307
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/512ba5ed4228c07c35956ecd7933314533f411ad
Submitter: "Zuul (22348)"
Branch: master

commit 512ba5ed4228c07c35956ecd7933314533f411ad
Author: Michele Baldessari <email address hidden>
Date: Mon Oct 4 11:20:59 2021 +0200

    Fix swift "Could not enable rsyncd" error

    The inclusing of rsync::server as a tag makes it error out as follows:
    2021-10-04T08:43:54.486557677+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/usr/bin/systemctl is-enabled -- rsyncd'
    2021-10-04T08:43:54.495188022+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/usr/bin/systemctl unmask -- rsyncd'
    2021-10-04T08:43:54.502673716+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/usr/bin/systemctl enable -- rsyncd'
    2021-10-04T08:43:54.511733823+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Error: Could not enable rsyncd:

    Let's make sure we noop the service completely. I believe this started
    showing on my CS9 env after https://github.com/puppetlabs/puppetlabs-rsync/commit/8f6a96587106a6c5eaa9d923be8f85e710c82992

    Tested and am able to deploy successfully again.

    Depends-On: https://review.opendev.org/c/openstack/puppet-tripleo/+/812338

    Closes-Bug: #1945962
    Change-Id: Ic39c146ca23a1adb85bb0b3a2119c37176eba332

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/813013

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/813013
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/d7874ae35833961fc55798833d795a2e3f0c53a2
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit d7874ae35833961fc55798833d795a2e3f0c53a2
Author: Michele Baldessari <email address hidden>
Date: Mon Oct 4 11:20:59 2021 +0200

    Fix swift "Could not enable rsyncd" error

    The inclusing of rsync::server as a tag makes it error out as follows:
    2021-10-04T08:43:54.486557677+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/usr/bin/systemctl is-enabled -- rsyncd'
    2021-10-04T08:43:54.495188022+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/usr/bin/systemctl unmask -- rsyncd'
    2021-10-04T08:43:54.502673716+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Debug: Executing: '/usr/bin/systemctl enable -- rsyncd'
    2021-10-04T08:43:54.511733823+00:00 stderr F <13>Oct 4 08:43:54 puppet-user: Error: Could not enable rsyncd:

    Let's make sure we noop the service completely. I believe this started
    showing on my CS9 env after https://github.com/puppetlabs/puppetlabs-rsync/commit/8f6a96587106a6c5eaa9d923be8f85e710c82992

    Tested and am able to deploy successfully again.

    Depends-On: https://review.opendev.org/c/openstack/puppet-tripleo/+/812389

    Closes-Bug: #1945962
    Change-Id: Ic39c146ca23a1adb85bb0b3a2119c37176eba332
    (cherry picked from commit 512ba5ed4228c07c35956ecd7933314533f411ad)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 15.1.0

This issue was fixed in the openstack/tripleo-heat-templates 15.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.