Ability to configure mutliple IPs for OVN SB DB connection

[Jakub Libosvar]

In order to make use of read-only connections for OVN metadata agent, we need a way in tripleo to make such configuration possible.

[Jakub Libosvar (libosvar)]

Fixed in https://review.opendev.org/c/openstack/puppet-tripleo/+/778066

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795050

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795154

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795155

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795268

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Jakub Libosvar <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795268
Reason: Fixed in https://review.opendev.org/c/openstack/puppet-tripleo/+/795155

[Bogdan Dobrelya (bogdando)]

set prio to high since raft cluster helps to better scale network operations (based on some internal inputs from PSI folks, feel free to expand it here)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/795154
Committed: https://opendev.org/openstack/puppet-tripleo/commit/fad7e3fb90f2f03e011fd245e5b60d510726d9e3
Submitter: "Zuul (22348)"
Branch: master

commit fad7e3fb90f2f03e011fd245e5b60d510726d9e3
Author: Alex Schultz <email address hidden>
Date: Mon Jun 7 09:56:59 2021 -0600

    Revert "Allow ovn_db_host to be of type array"

    We shouldn't override the hieradata but rather be explicit about which
    mode we're operating in. e.g. pacemaker or not. This will help in
    troubleshooting and not rely on hieradata overrides to work.

    This reverts commit 0b51d8258c4a0618ec6f2abd8f86bfe6943cd51f.

    Related-Bug: #1931133
    Change-Id: Id8df4fe5ce26dbcdeb7ba073ecb2199cf392b03b

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/795155
Committed: https://opendev.org/openstack/puppet-tripleo/commit/dee8091c8904105df2747a6639fe2779726b28df
Submitter: "Zuul (22348)"
Branch: master

commit dee8091c8904105df2747a6639fe2779726b28df
Author: Alex Schultz <email address hidden>
Date: Mon Jun 7 10:17:48 2021 -0600

    Add support for ovn clustered databases

    This patch adds support for managing the ovn connection correctly when
    ovn is handling clustering instead of pacemaker. By default if the
    parameter is not enabled, the pacemaker managed way is assumed.

    Change-Id: I97442478d77d222fdd428eebd270c08df08237f6
    Related-Bug: #1931133

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795454

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795478

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Jakub Libosvar <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795050

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Jakub Libosvar <email address hidden>" on branch: stable/victoria
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795049

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/795454
Committed: https://opendev.org/openstack/puppet-tripleo/commit/b6f2ff4320616b840ebcf0907b8339decfbedad0
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit b6f2ff4320616b840ebcf0907b8339decfbedad0
Author: Alex Schultz <email address hidden>
Date: Mon Jun 7 09:56:59 2021 -0600

    Revert "Allow ovn_db_host to be of type array"

    We shouldn't override the hieradata but rather be explicit about which
    mode we're operating in. e.g. pacemaker or not. This will help in
    troubleshooting and not rely on hieradata overrides to work.

    This reverts commit 0b51d8258c4a0618ec6f2abd8f86bfe6943cd51f.

    Related-Bug: #1931133
    Change-Id: Id8df4fe5ce26dbcdeb7ba073ecb2199cf392b03b
    (cherry picked from commit fad7e3fb90f2f03e011fd245e5b60d510726d9e3)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/795478
Committed: https://opendev.org/openstack/puppet-tripleo/commit/22e79f3c33a08ada21d8e0d3e26f4f9ae185983b
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 22e79f3c33a08ada21d8e0d3e26f4f9ae185983b
Author: Alex Schultz <email address hidden>
Date: Mon Jun 7 10:17:48 2021 -0600

    Add support for ovn clustered databases

    This patch adds support for managing the ovn connection correctly when
    ovn is handling clustering instead of pacemaker. By default if the
    parameter is not enabled, the pacemaker managed way is assumed.

    Change-Id: I97442478d77d222fdd428eebd270c08df08237f6
    Related-Bug: #1931133

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795763

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Michele Baldessari <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/779356

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/795763
Committed: https://opendev.org/openstack/puppet-tripleo/commit/d1b1f7c675e33f2d7b0f3a5583def776ecc7e87c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit d1b1f7c675e33f2d7b0f3a5583def776ecc7e87c
Author: Alex Schultz <email address hidden>
Date: Mon Jun 7 10:17:48 2021 -0600

    Add support for ovn clustered databases

    This patch adds support for managing the ovn connection correctly when
    ovn is handling clustering instead of pacemaker. By default if the
    parameter is not enabled, the pacemaker managed way is assumed.

    Conflicts:
      manifests/profile/base/neutron/agents/ovn.pp (Due to missing
      "enable_ovn_match_northd => true," line)

    Change-Id: I97442478d77d222fdd428eebd270c08df08237f6
    Related-Bug: #1931133

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/795890

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/795890
Committed: https://opendev.org/openstack/puppet-tripleo/commit/3bcfb9deefd16c77608ea4cbedc09dcd6d16a7a6
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 3bcfb9deefd16c77608ea4cbedc09dcd6d16a7a6
Author: Alex Schultz <email address hidden>
Date: Mon Jun 7 10:17:48 2021 -0600

    Add support for ovn clustered databases

    This patch adds support for managing the ovn connection correctly when
    ovn is handling clustering instead of pacemaker. By default if the
    parameter is not enabled, the pacemaker managed way is assumed.

    Conflicts:
      manifests/profile/base/neutron/agents/ovn.pp (Due to missing
      "enable_ovn_match_northd => true," line)

    Change-Id: I97442478d77d222fdd428eebd270c08df08237f6
    Related-Bug: #1931133
    (cherry picked from commit d1b1f7c675e33f2d7b0f3a5583def776ecc7e87c)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/796149

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/796149
Committed: https://opendev.org/openstack/puppet-tripleo/commit/79f06794fdc85af625248c55e97aea353531ee83
Submitter: "Zuul (22348)"
Branch: stable/train

commit 79f06794fdc85af625248c55e97aea353531ee83
Author: Alex Schultz <email address hidden>
Date: Mon Jun 7 10:17:48 2021 -0600

    Add support for ovn clustered databases

    This patch adds support for managing the ovn connection correctly when
    ovn is handling clustering instead of pacemaker. By default if the
    parameter is not enabled, the pacemaker managed way is assumed.

    Conflicts:
      manifests/profile/base/neutron/agents/ovn.pp (Due to missing
      "enable_ovn_match_northd => true," line) and other context
      manifests/profile/base/neutron/ovn_metadata.pp
      manifests/profile/base/neutron/plugins/ml2/ovn.pp

    Change-Id: I97442478d77d222fdd428eebd270c08df08237f6
    Related-Bug: #1931133
    (cherry picked from commit d1b1f7c675e33f2d7b0f3a5583def776ecc7e87c)
    (cherry picked from commit 3bcfb9deefd16c77608ea4cbedc09dcd6d16a7a6)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/775444
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/baf4a16149d2a31ccb331cc96b89871e71c00734
Submitter: "Zuul (22348)"
Branch: master

commit baf4a16149d2a31ccb331cc96b89871e71c00734
Author: Carlos Goncalves <email address hidden>
Date: Fri Feb 12 21:08:59 2021 +0100

    OVN DBs clustering

    We introduce support for running both the NB and SB OVN databases in
    clustered mode. This OVN DBs clustered mode is based on OVNs own
    clustering protocol and does not rely on pacemaker.

    Clustering the two OVN databases increases reliability. The cluster
    works in active-active mode and has the potential to be more
    resilient and performant.

    See
    https://docs.openvswitch.org/en/latest/ref/ovsdb.7/#clustered-database-service-model
    for more information.

    Co-Authored-By: Michele Baldessari <email address hidden>

    Related-Bug: #1931133
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/776969
    Depends-On: https://review.opendev.org/c/openstack/puppet-tripleo/+/795155

    Change-Id: I59bfe69dbb5f3d525ac6f6d655577d24036328c0

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/801656

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/803313

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/803313
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/15433f131ceee8e8df6e8ca60b0703467fbbf310
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 15433f131ceee8e8df6e8ca60b0703467fbbf310
Author: Carlos Goncalves <email address hidden>
Date: Fri Feb 12 21:08:59 2021 +0100

    OVN DBs clustering

    We introduce support for running both the NB and SB OVN databases in
    clustered mode. This OVN DBs clustered mode is based on OVNs own
    clustering protocol and does not rely on pacemaker.

    Clustering the two OVN databases increases reliability. The cluster
    works in active-active mode and has the potential to be more
    resilient and performant.

    See
    https://docs.openvswitch.org/en/latest/ref/ovsdb.7/#clustered-database-service-model
    for more information.

    For backport simplicity we also add I50cf3b7d79d8cd139ae514438e147df73901a366
    ("Fix typo in ovn-dbs-cluster northd kolla config file") which
    is a cherry-pick + squash of commit 1115698c14788555510edbe1760bbc9cc9110dff,
    so we avoid ovn_northd connecting only to the local db via unix socket.

    Co-Authored-By: Michele Baldessari <email address hidden>

    Related-Bug: #1931133
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/776969
    Depends-On: https://review.opendev.org/c/openstack/puppet-tripleo/+/795478

    Change-Id: I59bfe69dbb5f3d525ac6f6d655577d24036328c0
    (cherry picked from commit baf4a16149d2a31ccb331cc96b89871e71c00734)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/804026

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/804026
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/40da6ed23462369add64c9c2907926eb632816d0
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 40da6ed23462369add64c9c2907926eb632816d0
Author: Michele Baldessari <email address hidden>
Date: Wed Aug 11 15:55:22 2021 +0200

    OVN DBs clustering

    We introduce support for running both the NB and SB OVN databases in
    clustered mode. This OVN DBs clustered mode is based on OVNs own
    clustering protocol and does not rely on pacemaker.

    Clustering the two OVN databases increases reliability. The cluster
    works in active-active mode and has the potential to be more
    resilient and performant.

    See
    https://docs.openvswitch.org/en/latest/ref/ovsdb.7/#clustered-database-service-model
    for more information.

    For backport simplicity we also add I50cf3b7d79d8cd139ae514438e147df73901a366
    ("Fix typo in ovn-dbs-cluster northd kolla config file") which
    is a cherry-pick + squash of commit 1115698c14788555510edbe1760bbc9cc9110dff,
    so we avoid ovn_northd connecting only to the local db via unix socket.

    Co-Authored-By: Michele Baldessari <email address hidden>

    Related-Bug: #1931133
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/776961
    Depends-On: https://review.opendev.org/c/openstack/puppet-tripleo/+/795763

    NB: Some changes for this victoria backport are needed:
    - Readd DefaultPasswords:
    - go back to the old way of doing TLS (i.e. no system-roles.certificate)
    - template version back to rocky
    - Set tripleo_container_manage_systemd_order: false (I believe it was a
      mistake to start with and we removed it in master as well)

    Change-Id: I59bfe69dbb5f3d525ac6f6d655577d24036328c0
    (cherry picked from commit baf4a16149d2a31ccb331cc96b89871e71c00734)
    (cherry picked from commit 15433f131ceee8e8df6e8ca60b0703467fbbf310)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/804515

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/804515
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/3d4063fcabe442d2aae527d51b3802b01f3056ab
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 3d4063fcabe442d2aae527d51b3802b01f3056ab
Author: Michele Baldessari <email address hidden>
Date: Wed Aug 11 15:55:22 2021 +0200

    OVN DBs clustering

    We introduce support for running both the NB and SB OVN databases in
    clustered mode. This OVN DBs clustered mode is based on OVNs own
    clustering protocol and does not rely on pacemaker.

    Clustering the two OVN databases increases reliability. The cluster
    works in active-active mode and has the potential to be more
    resilient and performant.

    See
    https://docs.openvswitch.org/en/latest/ref/ovsdb.7/#clustered-database-service-model
    for more information.

    For backport simplicity we also add I50cf3b7d79d8cd139ae514438e147df73901a366
    ("Fix typo in ovn-dbs-cluster northd kolla config file") which
    is a cherry-pick + squash of commit 1115698c14788555510edbe1760bbc9cc9110dff,
    so we avoid ovn_northd connecting only to the local db via unix socket.

    Co-Authored-By: Michele Baldessari <email address hidden>

    Related-Bug: #1931133
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/804435
    Depends-On: https://review.opendev.org/c/openstack/puppet-tripleo/+/795763

    NB: Some changes for this ussuri (just like for victoria) backport are needed:
    - Readd DefaultPasswords:
    - go back to the old way of doing TLS (i.e. no system-roles.certificate)
    - template version back to rocky
    - Set tripleo_container_manage_systemd_order: false (I believe it was a
      mistake to start with and we removed it in master as well)

    Change-Id: I59bfe69dbb5f3d525ac6f6d655577d24036328c0
    (cherry picked from commit baf4a16149d2a31ccb331cc96b89871e71c00734)
    (cherry picked from commit 15433f131ceee8e8df6e8ca60b0703467fbbf310)
    (cherry picked from commit 40da6ed23462369add64c9c2907926eb632816d0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/801656
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/2494eea763cb6cae3e6fc0e3029447cce74d2476
Submitter: "Zuul (22348)"
Branch: stable/train

commit 2494eea763cb6cae3e6fc0e3029447cce74d2476
Author: Carlos Goncalves <email address hidden>
Date: Fri Feb 12 21:08:59 2021 +0100

    OVN DBs clustering

    We introduce support for running both the NB and SB OVN databases in
    clustered mode. This OVN DBs clustered mode is based on OVNs own
    clustering protocol and does not rely on pacemaker.

    Clustering the two OVN databases increases reliability. The cluster
    works in active-active mode and has the potential to be more
    resilient and performant.

    See
    https://docs.openvswitch.org/en/latest/ref/ovsdb.7/#clustered-database-service-model
    for more information.

    Co-Authored-By: Michele Baldessari <email address hidden>

    NB: Some changes for this train backport are needed:
    - firewall_rules
    - go back to the old way of doing TLS (i.e. no system-roles.certificate)
    - template version back to rocky
    - Add 'DefaultPasswords:' parameter
    - Set tripleo_container_manage_systemd_order: false (I believe it was a
      mistake to start with)
    - Include I50cf3b7d79d8cd139ae514438e147df73901a366 (fix typo in northd)

    Related-Bug: #1931133
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ansible/+/801654
    Depends-On: https://review.opendev.org/c/openstack/puppet-tripleo/+/796149

    Change-Id: I59bfe69dbb5f3d525ac6f6d655577d24036328c0
    (cherry picked from commit baf4a16149d2a31ccb331cc96b89871e71c00734)

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Ghanshyam <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796512
Reason: TrieplO project is retiring now, for details, please see https://review.opendev.org/c/openstack/governance/+/905145 or reach out to OpenStack TC.