puppet-openstack-lint-ubuntu-focal fails with the latest lint packages

Bug #1928079 reported by Takashi Kajinami on 2021-05-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-tripleo
In Progress
Critical
Takashi Kajinami
tripleo
Undecided
Unassigned

Bug Description

Since we removed pins of lint packages, puppet-openstack-lint-ubuntu-focal fails with the following lint errors.

manifests/host/liquidio/compute.pp:11:WARNING: No matching class parameter for documentation of tripleo::host::liquidio::compute::controller_node_ip
manifests/profile/base/database/mysql.pp:224:WARNING: absolute class name reference
manifests/profile/base/database/redis.pp:102:WARNING: absolute class name reference
manifests/profile/base/database/redis.pp:115:WARNING: absolute class name reference
manifests/profile/base/glance/api.pp:197:WARNING: absolute class name reference
manifests/profile/base/haproxy.pp:70:WARNING: absolute class name reference
manifests/profile/pacemaker/database/mysql.pp:272:WARNING: absolute class name reference
manifests/profile/pacemaker/database/mysql_bundle.pp:515:WARNING: absolute class name reference
manifests/profile/pacemaker/database/redis.pp:157:WARNING: absolute class name reference
manifests/profile/pacemaker/database/redis.pp:171:WARNING: absolute class name reference
manifests/profile/pacemaker/database/redis.pp:244:WARNING: absolute class name reference
manifests/profile/pacemaker/database/redis_bundle.pp:198:WARNING: absolute class name reference
manifests/profile/pacemaker/database/redis_bundle.pp:212:WARNING: absolute class name reference
manifests/profile/pacemaker/rabbitmq.pp:104:WARNING: absolute class name reference
manifests/profile/pacemaker/rabbitmq.pp:145:WARNING: absolute class name reference
manifests/profile/pacemaker/rabbitmq_bundle.pp:178:WARNING: absolute class name reference
manifests/profile/pacemaker/rabbitmq_bundle.pp:342:WARNING: absolute class name reference

Example: https://781c216da1c4dc2d1ba5-5ac1a082e8ecb95d568fc64f7fecfb2c.ssl.cf2.rackcdn.com/790665/1/check/puppet-openstack-lint-ubuntu-focal/4c985d9/job-output.txt

Changed in tripleo:
importance: Undecided → Critical
assignee: nobody → Takashi Kajinami (kajinamit)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)
Revision history for this message
Takashi Kajinami (kajinamit) wrote :

Adding an invalid bug for tripleo to ensure this is visible to all tripleo folks.

affects: tripleo → puppet-tripleo
Changed in tripleo:
status: New → Invalid
Changed in tripleo:
status: Invalid → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/790676
Committed: https://opendev.org/openstack/puppet-tripleo/commit/f08d83de05ba4303588e0ba40e240fb1cefae86a
Submitter: "Zuul (22348)"
Branch: master

commit f08d83de05ba4303588e0ba40e240fb1cefae86a
Author: Takashi Kajinami <email address hidden>
Date: Tue May 11 21:02:07 2021 +0900

    Fix lint errors with the latest lint packages

    This change fixes the lint errors detected since we removed pins of
    lint packages.
    Note that this change also replaces absolute name used to call
    the tripleo::stunnel::service_proxy resource type, which is not yet
    detected by the latest lint rules.

    Closes-Bug: #1928079
    Change-Id: I12ba801db92cb3df1d05f14f4c150ac765f0b874

Changed in tripleo:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers