fs039 tls scenario broken: nova vnc haproxy config errors out: The service_network for this service is undefined

[Michele Baldessari]

Seen here:
https://logserver.rdoproject.org/34/780934/6/openstack-check/tripleo-ci-centos-8-ovb-3ctlr_1comp_1supp-featureset039/d2d5468/logs/overcloud-controller-0/var/log/containers/stdouts/container-puppet-haproxy.log.txt.gz

2021-03-17T17:38:04.773582397+00:00 stderr F <13>Mar 17 17:38:04 puppet-user: Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, The service_network for this service is undefined. Can't configure TLS for the internal network. (file: /etc/puppet/modules/tripleo/manifests/haproxy/endpoint.pp, line: 201, column: 7) (file: /etc/puppet/modules/tripleo/manifests/haproxy.pp, line: 1031) on node overcloud-controller-0.ooo.test
2021-03-17T17:38:04.927012761+00:00 stderr F + rc=1

Seems to me that: "Use single NovaLibvirtNetwork to configure instance console components"
Icef2481b65b41b524ad44eeecfbee4451006e1d2

Needs a corresponding puppet-tripleo change, since we have code that still erfences the old network here:
https://github.com/openstack/puppet-tripleo/blob/master/manifests/haproxy.pp#L641

  $nova_novncproxy_network = hiera('nova_vnc_proxy_network', undef),

I.e. nova_vnc_proxy_network does not exist anymore: https://logserver.rdoproject.org/34/780934/6/openstack-check/tripleo-ci-centos-8-ovb-3ctlr_1comp_1supp-featureset039/d2d5468/logs/overcloud-controller-0/etc/puppet/hieradata/all_nodes.json.txt.gz

[Michele Baldessari (michele)]

WIP fix at https://review.opendev.org/c/openstack/puppet-tripleo/+/781157

Testing the WIP fix via https://review.opendev.org/c/openstack/tripleo-heat-templates/+/780934

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 11.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 13.6.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 12.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 14.1.0 release.