puppet-openstack-unit-5.5-centos-7 fails with "Evaluation Error: Operator '[]' is not applicable to an Undef Value."

[Takashi Kajinami]

Currently puppet-openstack-unit-5.5-centos-7 in puppet-triple ci job is failing.

Failure/Error: is_expected.to compile.with_all_deps
  error during compilation: Evaluation Error: Operator '[]' is not applicable to an Undef Value. (file: /home/zuul/workspace/spec/fixtures/modules/collectd/manifests/params.pp, line: 6, column: 32) on node <node name>

[Takashi Kajinami (kajinamit)]

The following log shows an example where we observe the failure.

https://e938d47020b675426ab4-7e40ce39ccab4ef0c73cf8dc5da9147c.ssl.cf1.rackcdn.com/685349/11/check/puppet-openstack-unit-5.5-centos-7/52aef2d/job-output.txt

-- snip --
2020-02-08 03:15:56.619529 | centos-7 | 1) tripleo::profile::base::metrics::collectd::sensubility on redhat-7-x86_64 behaves like tripleo::profile::base::metrics::collectd::sensubility with defaults and sudo rule defined has sudoers file for appropriate user with relevant rule
2020-02-08 03:15:56.619613 | centos-7 | Failure/Error: is_expected.to compile.with_all_deps
2020-02-08 03:15:56.619846 | centos-7 | error during compilation: Evaluation Error: Operator '[]' is not applicable to an Undef Value. (file: /home/zuul/workspace/spec/fixtures/modules/collectd/manifests/params.pp, line: 6, column: 32) on node centos-7-ovh-gra1-0014436384
2020-02-08 03:15:56.620004 | centos-7 | Shared Example Group: "tripleo::profile::base::metrics::collectd::sensubility" called from ./spec/classes/tripleo_profile_base_metrics_collectd_sensubility_spec.rb:40
2020-02-08 03:15:56.620137 | centos-7 | # ./spec/classes/tripleo_profile_base_metrics_collectd_sensubility_spec.rb:26:in `block (4 levels) in <top (required)>'
2020-02-08 03:15:56.620172 | centos-7 |
-- snip --

[Takashi Kajinami (kajinamit)]

The following commit made puppet-collected require facts['networking']['hostname'], but it is available since facter 3.0.0[2].
We use facter facter 2.5.7 on current centos 7 jobs, so we need to pin puppet-collectd to avoid the error.

[1] https://github.com/voxpupuli/puppet-collectd/commit/bda9e87a412324ac2f11a5e1672d4630be3b09a7
[2] https://github.com/puppetlabs/facter/commit/a33b743c74b10f6860c894ddcba3a7c8b4b8de07

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/706662

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/706662
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=e72ce5e4c5d89f985bc37a010bd209a33b68a420
Submitter: Zuul
Branch: master

commit e72ce5e4c5d89f985bc37a010bd209a33b68a420
Author: Takashi Kajinami <email address hidden>
Date: Sat Feb 8 19:05:46 2020 +0900

    Pin puppet-collectd

    Pin puppet-collectd because its recent change[1] broke its
    compatibility with facter 2.X.X, which is currently required
    in centos-7 jobs.

    [1] https://github.com/voxpupuli/puppet-collectd/commit/bda9e87a412324ac2f11a5e1672d4630be3b09a7

    Change-Id: Ie3174349b23a46d527358e0d57f9ccbce73dec49
    Closes-Bug: #1862434

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 12.1.0 release.