tripleo

cannot customize mysql haproxy's listen stanza

Bug #1858775 reported by Michele Baldessari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Michele Baldessari
tripleo ussuri-1

Bug Description

Most haproxy stanzas can be customized with the following hiera keys:
 tripleo::haproxy::cinder::options:
      bind-process: 2
    tripleo::haproxy::glance_api::options:
      bind-process: 2
    tripleo::haproxy::mysql::options:
      bind-process: 2

The problem is that for that to work a stanza has to use the tripleo::haproxy::endpoint class. This means that it won't work for mysql

OpenStack Infra (hudson-openstack)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
Michele Baldessari (michele) wrote :

https://review.opendev.org/701401

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.opendev.org/701401
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=c42c5aa67828c8277d676e609bc828eb1dd1ba37
Submitter: Zuul
Branch: master

commit c42c5aa67828c8277d676e609bc828eb1dd1ba37
Author: Michele Baldessari <email address hidden>
Date: Tue Jan 7 17:36:37 2020 +0100

    Allow mysql haproxy stanza do be customized

    We introduce a new tripleo::haproxy parameter called mysql_custom_listen_options
    which can be used to customize mysql listen options in haproxy's config.

    Tested as follows:
    parameter_defaults:
      ExtraConfig:
        tripleo::haproxy::haproxy_default_timeout:
          - 'http-request 10s'
          - 'queue 2m'
          - 'connect 10s'
          - 'client 5m'
          - 'server 5m'
          - 'check 10s'
        tripleo::haproxy::cinder::options:
          bind-process: 2
        tripleo::haproxy::glance_api::options:
          bind-process: 2
        tripleo::haproxy::mysql_custom_listen_options:
          bind-process: 2

    Observed that haproxy's mysql stanza had:
    listen mysql
      bind 172.17.1.91:3306 transparent
      bind-process 2
      option tcpka
      option httpchk

    Before this patch this was not the case and the tripleo::haproxy::<mysql>::options just got ignored.

    Closes-Bug: #1858775

    Change-Id: Ia0ecca5b54c1ca51898035e641665150dbdac9f7

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/701702

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/train)

Reviewed: https://review.opendev.org/701702
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=64951b5c124b90e97404a7ad5c1439a768afbb2a
Submitter: Zuul
Branch: stable/train

commit 64951b5c124b90e97404a7ad5c1439a768afbb2a
Author: Michele Baldessari <email address hidden>
Date: Tue Jan 7 17:36:37 2020 +0100

    Allow mysql haproxy stanza do be customized

    We introduce a new tripleo::haproxy parameter called mysql_custom_listen_options
    which can be used to customize mysql listen options in haproxy's config.

    Tested as follows:
    parameter_defaults:
      ExtraConfig:
        tripleo::haproxy::haproxy_default_timeout:
          - 'http-request 10s'
          - 'queue 2m'
          - 'connect 10s'
          - 'client 5m'
          - 'server 5m'
          - 'check 10s'
        tripleo::haproxy::cinder::options:
          bind-process: 2
        tripleo::haproxy::glance_api::options:
          bind-process: 2
        tripleo::haproxy::mysql_custom_listen_options:
          bind-process: 2

    Observed that haproxy's mysql stanza had:
    listen mysql
      bind 172.17.1.91:3306 transparent
      bind-process 2
      option tcpka
      option httpchk

    Before this patch this was not the case and the tripleo::haproxy::<mysql>::options just got ignored.

    Closes-Bug: #1858775

    Change-Id: Ia0ecca5b54c1ca51898035e641665150dbdac9f7
    (cherry picked from commit c42c5aa67828c8277d676e609bc828eb1dd1ba37)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/702016

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/702017

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/stein)

Reviewed: https://review.opendev.org/702016
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=45a4a611144d6fd15bba96c17758c9857d83e59c
Submitter: Zuul
Branch: stable/stein

commit 45a4a611144d6fd15bba96c17758c9857d83e59c
Author: Michele Baldessari <email address hidden>
Date: Tue Jan 7 17:36:37 2020 +0100

    Allow mysql haproxy stanza do be customized

    We introduce a new tripleo::haproxy parameter called mysql_custom_listen_options
    which can be used to customize mysql listen options in haproxy's config.

    Tested as follows:
    parameter_defaults:
      ExtraConfig:
        tripleo::haproxy::haproxy_default_timeout:
          - 'http-request 10s'
          - 'queue 2m'
          - 'connect 10s'
          - 'client 5m'
          - 'server 5m'
          - 'check 10s'
        tripleo::haproxy::cinder::options:
          bind-process: 2
        tripleo::haproxy::glance_api::options:
          bind-process: 2
        tripleo::haproxy::mysql_custom_listen_options:
          bind-process: 2

    Observed that haproxy's mysql stanza had:
    listen mysql
      bind 172.17.1.91:3306 transparent
      bind-process 2
      option tcpka
      option httpchk

    Before this patch this was not the case and the tripleo::haproxy::<mysql>::options just got ignored.

    Closes-Bug: #1858775

    Change-Id: Ia0ecca5b54c1ca51898035e641665150dbdac9f7
    (cherry picked from commit c42c5aa67828c8277d676e609bc828eb1dd1ba37)
    (cherry picked from commit 64951b5c124b90e97404a7ad5c1439a768afbb2a)

tags: added: in-stable-stein
tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/rocky)

Reviewed: https://review.opendev.org/702017
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=48ff6171b51a70e6800fa87a7aec124ad6110cda
Submitter: Zuul
Branch: stable/rocky

commit 48ff6171b51a70e6800fa87a7aec124ad6110cda
Author: Michele Baldessari <email address hidden>
Date: Tue Jan 7 17:36:37 2020 +0100

    Allow mysql haproxy stanza do be customized

    We introduce a new tripleo::haproxy parameter called mysql_custom_listen_options
    which can be used to customize mysql listen options in haproxy's config.

    Tested as follows:
    parameter_defaults:
      ExtraConfig:
        tripleo::haproxy::haproxy_default_timeout:
          - 'http-request 10s'
          - 'queue 2m'
          - 'connect 10s'
          - 'client 5m'
          - 'server 5m'
          - 'check 10s'
        tripleo::haproxy::cinder::options:
          bind-process: 2
        tripleo::haproxy::glance_api::options:
          bind-process: 2
        tripleo::haproxy::mysql_custom_listen_options:
          bind-process: 2

    Observed that haproxy's mysql stanza had:
    listen mysql
      bind 172.17.1.91:3306 transparent
      bind-process 2
      option tcpka
      option httpchk

    Before this patch this was not the case and the tripleo::haproxy::<mysql>::options just got ignored.

    Closes-Bug: #1858775

    Change-Id: Ia0ecca5b54c1ca51898035e641665150dbdac9f7
    (cherry picked from commit c42c5aa67828c8277d676e609bc828eb1dd1ba37)
    (cherry picked from commit 64951b5c124b90e97404a7ad5c1439a768afbb2a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/702066

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/queens)

Reviewed: https://review.opendev.org/702066
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=7c96510dc4b4c70f2927d2b3c89ba562b588159c
Submitter: Zuul
Branch: stable/queens

commit 7c96510dc4b4c70f2927d2b3c89ba562b588159c
Author: Michele Baldessari <email address hidden>
Date: Tue Jan 7 17:36:37 2020 +0100

    Allow mysql haproxy stanza do be customized

    We introduce a new tripleo::haproxy parameter called mysql_custom_listen_options
    which can be used to customize mysql listen options in haproxy's config.

    Tested as follows:
    parameter_defaults:
      ExtraConfig:
        tripleo::haproxy::haproxy_default_timeout:
          - 'http-request 10s'
          - 'queue 2m'
          - 'connect 10s'
          - 'client 5m'
          - 'server 5m'
          - 'check 10s'
        tripleo::haproxy::cinder::options:
          bind-process: 2
        tripleo::haproxy::glance_api::options:
          bind-process: 2
        tripleo::haproxy::mysql_custom_listen_options:
          bind-process: 2

    Observed that haproxy's mysql stanza had:
    listen mysql
      bind 172.17.1.91:3306 transparent
      bind-process 2
      option tcpka
      option httpchk

    Before this patch this was not the case and the tripleo::haproxy::<mysql>::options just got ignored.

    Closes-Bug: #1858775

    Change-Id: Ia0ecca5b54c1ca51898035e641665150dbdac9f7
    (cherry picked from commit c42c5aa67828c8277d676e609bc828eb1dd1ba37)
    (cherry picked from commit 64951b5c124b90e97404a7ad5c1439a768afbb2a)
    (cherry picked from commit 48ff6171b51a70e6800fa87a7aec124ad6110cda)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 12.1.0

This issue was fixed in the openstack/puppet-tripleo 12.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 11.5.0

This issue was fixed in the openstack/puppet-tripleo 11.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo rocky-eol

This issue was fixed in the openstack/puppet-tripleo rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo queens-eol

This issue was fixed in the openstack/puppet-tripleo queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo stein-eol

This issue was fixed in the openstack/puppet-tripleo stein-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.