tripleo

service_names was removed but is still needed

Bug #1855138 reported by Emilien Macchi on 2019-12-04

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Emilien Macchi	tripleo ussuri-1

Bug Description

service_names used to exist until Train which was incorrectly removed because service_names was scoped to the role.

Context: https://bugzilla.redhat.com/show_bug.cgi?id=1769872

Tags:

Emilien Macchi (emilienm) on 2019-12-04

Changed in tripleo:
milestone:	none → ussuri-1
assignee:	nobody → Emilien Macchi (emilienm)
importance:	Undecided → High
status:	New → Triaged
tags:	added: train-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-04: Related fix proposed to tripleo-ansible (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/697320

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-04: Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/697323

Changed in tripleo:
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-04: Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.opendev.org/697325

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-05: Related fix proposed to tripleo-ansible (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/697463

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-05: Related fix proposed to tripleo-heat-templates (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/697464

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-05: Fix proposed to puppet-tripleo (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/697466

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-05: Related fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/697320
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=114c3c97f400fb99591484e65ed198cbd7ffe584
Submitter: Zuul
Branch: master

commit 114c3c97f400fb99591484e65ed198cbd7ffe584
Author: Emilien Macchi <email address hidden>
Date: Wed Dec 4 11:52:52 2019 -0500

tripleo-hieradata: re-enable "service_names"

    "service_names" was a useful hieradata which listed the services enabled
    for a specific roles vs "enabled_services" which are for all the
    services enabled in the cloud, no matter the role.

This is re-added for backward compatibility.

Change-Id: I75b1112089a66cf5db0a2fd651bb24428cf861fd
Related-Bug: #1855138

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-05: Related fix merged to tripleo-ansible (stable/train)

Reviewed: https://review.opendev.org/697463
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=c97ce3e1c793f5350750502009b26a59bc3e9d32
Submitter: Zuul
Branch: stable/train

commit c97ce3e1c793f5350750502009b26a59bc3e9d32
Author: Emilien Macchi <email address hidden>
Date: Wed Dec 4 11:52:52 2019 -0500

tripleo-hieradata: re-enable "service_names"

    "service_names" was a useful hieradata which listed the services enabled
    for a specific roles vs "enabled_services" which are for all the
    services enabled in the cloud, no matter the role.

This is re-added for backward compatibility.

    Change-Id: I75b1112089a66cf5db0a2fd651bb24428cf861fd
    Related-Bug: #1855138
    (cherry picked from commit 114c3c97f400fb99591484e65ed198cbd7ffe584)

tags:

added: in-stable-train

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-06: Related fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/697464
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d8b060727171fee75eb9adba16258c6b0c420ef8
Submitter: Zuul
Branch: stable/train

commit d8b060727171fee75eb9adba16258c6b0c420ef8
Author: Emilien Macchi <email address hidden>
Date: Wed Dec 4 12:01:23 2019 -0500

Re-enable "service_names" hieradata

    "service_names" was a useful hieradata which listed the services enabled
    for a specific roles vs "enabled_services" which are for all the
    services enabled in the cloud, no matter the role.

This is re-added for backward compatibility.

    Depends-On: I75b1112089a66cf5db0a2fd651bb24428cf861fd
    Related-Bug: #1855138
    Change-Id: I7339b8791817bdaffa65c928d424796114efdf57
    (cherry picked from commit b5eff6783050a0449d4da1027e38dcee17672c66)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-06: Related fix merged to tripleo-heat-templates (master)

#10

Reviewed: https://review.opendev.org/697323
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b5eff6783050a0449d4da1027e38dcee17672c66
Submitter: Zuul
Branch: master

commit b5eff6783050a0449d4da1027e38dcee17672c66
Author: Emilien Macchi <email address hidden>
Date: Wed Dec 4 12:01:23 2019 -0500

Re-enable "service_names" hieradata

    "service_names" was a useful hieradata which listed the services enabled
    for a specific roles vs "enabled_services" which are for all the
    services enabled in the cloud, no matter the role.

This is re-added for backward compatibility.

    Depends-On: I75b1112089a66cf5db0a2fd651bb24428cf861fd
    Related-Bug: #1855138
    Change-Id: I7339b8791817bdaffa65c928d424796114efdf57

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-06: Fix merged to puppet-tripleo (master)

#11

Reviewed: https://review.opendev.org/697325
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=950caffea800c4f7196cd511f459b7277a137e26
Submitter: Zuul
Branch: master

commit 950caffea800c4f7196cd511f459b7277a137e26
Author: Emilien Macchi <email address hidden>
Date: Wed Dec 4 17:07:08 2019 +0000

Revert "Replace hiera('service_names') by hiera('enabled_services')"

This reverts commit 7970733cf1483fab466f205e57c9ea224f051c94.

Depends-On: I7339b8791817bdaffa65c928d424796114efdf57
Change-Id: I380f631de03eb3baddac80661e4c7632180b1d64

Closes-Bug: #1855138

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-06: Related fix proposed to tripleo-heat-templates (master)

#12

Related fix proposed to branch: master
Review: https://review.opendev.org/697726

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-06: Related fix proposed to tripleo-heat-templates (stable/train)

#13

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/697727

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-10: Related fix merged to tripleo-heat-templates (master)

#14

Reviewed: https://review.opendev.org/697726
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d0563f185b1cd08ad924f693d68a2f455ddd5722
Submitter: Zuul
Branch: master

commit d0563f185b1cd08ad924f693d68a2f455ddd5722
Author: Emilien Macchi <email address hidden>
Date: Fri Dec 6 17:02:35 2019 -0500

overcloud/service_names: merge service_names & enabled_services

    When building ServiceNames, make sure we merge the YAQL results of both
    enabled_services & service_names queries; so we don't end up with
    duplicates.

Change-Id: I1f062b8b9f936e6fbf2febf64244e91b59b8ba1b
Related-Bug: #1855138

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-11: Related fix merged to tripleo-heat-templates (stable/train)

#15

Reviewed: https://review.opendev.org/697727
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e2326868ed9d15592876a69809c5fbf88eb12880
Submitter: Zuul
Branch: stable/train

commit e2326868ed9d15592876a69809c5fbf88eb12880
Author: Emilien Macchi <email address hidden>
Date: Fri Dec 6 17:02:35 2019 -0500

overcloud/service_names: merge service_names & enabled_services

    When building ServiceNames, make sure we merge the YAQL results of both
    enabled_services & service_names queries; so we don't end up with
    duplicates.

    Change-Id: I1f062b8b9f936e6fbf2febf64244e91b59b8ba1b
    Related-Bug: #1855138
    (cherry picked from commit f5d8df16d9e7d5008ec726cb33bec9c588fbf7fe)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-12-12: Fix merged to puppet-tripleo (stable/train)

#16

Reviewed: https://review.opendev.org/697466
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=e7332417b2d741030bc27cdc9bb1c1491ce5e68e
Submitter: Zuul
Branch: stable/train

commit e7332417b2d741030bc27cdc9bb1c1491ce5e68e
Author: Emilien Macchi <email address hidden>
Date: Wed Dec 4 17:07:08 2019 +0000

Revert "Replace hiera('service_names') by hiera('enabled_services')"

This reverts commit 7970733cf1483fab466f205e57c9ea224f051c94.

Depends-On: I1f062b8b9f936e6fbf2febf64244e91b59b8ba1b

    Closes-Bug: #1855138
    (cherry picked from commit 950caffea800c4f7196cd511f459b7277a137e26)
    Change-Id: I44dfe2f0aff699aca78577b1e38098533a634520