ha containers hardcode container's log-driver

Bug #1853517 reported by Michele Baldessari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Michele Baldessari

Bug Description

Currently in puppet-tripleo for the HA container we hardcode the following:
 options => "--user=root --log-driver=journald -e KOLLA_CONFIG_STRATEGY=COPY_ALWAYS${tls_priorities_real}",

Since at least podman had some changes in tmers of supported driver backends (and bugs) it's best if we make this configurable. While we're at it we should also switch to k8s-file as a driver which is what all other containers are using

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.opendev.org/695578

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.opendev.org/695578
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=bad716070a70b258c110d4ef1feca422b14a9a98
Submitter: Zuul
Branch: master

commit bad716070a70b258c110d4ef1feca422b14a9a98
Author: Michele Baldessari <email address hidden>
Date: Thu Nov 21 22:02:13 2019 +0100

    Switch HA containers to k8s-file log-driver and make it a parameter

    Currently in puppet-tripleo for the HA container we hardcode the following:
     options => "--user=root --log-driver=journald -e KOLLA_CONFIG_STRATEGY=COPY_ALWAYS${tls_priorities_real}",

    Since at least podman had some changes in terms of supported driver
    backends (and bugs) it's best if we make this configurable. While we're
    at it we should also switch to k8s-file as a driver when podman is being
    used which is what all other containers are using. When docker is the
    default container_cli we will stick to journald as usual.

    Tested this on a Train environment and successfully verified that
    we still see the correct logs in /var/log/containers/.../...

    Change-Id: I5b1483826f816d11a064a937d59f9a8f468315a5
    Closes-Bug: #1853517

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/695734

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/train)

Reviewed: https://review.opendev.org/695734
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=bb277689eaa7d61d88be5c360a0428b466bd5a7a
Submitter: Zuul
Branch: stable/train

commit bb277689eaa7d61d88be5c360a0428b466bd5a7a
Author: Michele Baldessari <email address hidden>
Date: Thu Nov 21 22:02:13 2019 +0100

    Switch HA containers to k8s-file log-driver and make it a parameter

    Currently in puppet-tripleo for the HA container we hardcode the following:
     options => "--user=root --log-driver=journald -e KOLLA_CONFIG_STRATEGY=COPY_ALWAYS${tls_priorities_real}",

    Since at least podman had some changes in terms of supported driver
    backends (and bugs) it's best if we make this configurable. While we're
    at it we should also switch to k8s-file as a driver when podman is being
    used which is what all other containers are using. When docker is the
    default container_cli we will stick to journald as usual.

    Tested this on a Train environment and successfully verified that
    we still see the correct logs in /var/log/containers/.../...

    Change-Id: I5b1483826f816d11a064a937d59f9a8f468315a5
    Closes-Bug: #1853517
    (cherry picked from commit bad716070a70b258c110d4ef1feca422b14a9a98)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 12.0.0

This issue was fixed in the openstack/puppet-tripleo 12.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 11.4.0

This issue was fixed in the openstack/puppet-tripleo 11.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.