Rocky promotion jobs fail on undercloud install

[Sagi (Sergey) Shnaidman]

Rocky promotion OVB jobs fail on undercloud install, which got timeout:

http://logs.rdoproject.org/openstack-periodic-24hr/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-rocky/27157f6/logs/undercloud/home/zuul/undercloud_install.log.txt.gz

2019-07-07 05:15:05 | TASK [Start containers for step 3] *********************************************
is the last task and then timeout.

[Sagi (Sergey) Shnaidman (sshnaidm)]

The difference between jobs is THT commits:
  openstack-tripleo-heat-templates-9.4.1-0.20190703173215.27cbefa.el7.noarch | openstack-tripleo-heat-templates-9.4.1-0.20190706021053.6311584.el7.noarch

Merge "ceilometer_agent_notification: disable-panko.yaml"
Merge "Per-Role krb-service-principal for CompactServices"
Per-Role krb-service-principal for CompactServices

These are patches:

https://review.opendev.org/#/c/668798/ - Per-Role krb-service-principal for CompactServices
https://review.opendev.org/#/c/668497/ - ceilometer_agent_notification: disable-panko.yaml

[Sagi (Sergey) Shnaidman (sshnaidm)]

Also facter-2.4.4-4.el7.x86_64 is updated to facter-3.9.3-7.el7.x86_64
and puppet-4.8.2-1.el7.noarch to puppet-4.8.2-2.el7.noarch

[Sagi (Sergey) Shnaidman (sshnaidm)]

Keepalived container fails:
https://logs.rdoproject.org/openstack-periodic-24hr/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-rocky/27157f6/logs/undercloud/var/log/extra/docker/containers/keepalived/stdout.log.txt.gz

*** Configuration line starting `interface` is missing a parameter after keyword `interface` at word position 2
Unexpected argument(s): | tee /var/log/keepalived.log
------< Global definitions >------
 Router ID = undercloud
 Smtp server = ::1
 Smtp server port = 25
 Smtp HELO name = undercloud.localdomain
 Smtp server connection timeout = 30
 Email notification from = keepalived@localdomain
 Email notification = root@localdomain
 Default interface = eth0
 LVS flush = false
 VRRP IPv4 mcast group = 224.0.0.18
 VRRP IPv6 mcast group = ff02::12
 Gratuitous ARP delay = 5
 Gratuitous ARP repeat = 5
 Gratuitous ARP refresh timer = 0
 Gratuitous ARP refresh repeat = 1
 Gratuitous ARP lower priority delay = 4294
 Gratuitous ARP lower priority repeat = -1
 Send advert after receive lower priority advert = true
 Send advert after receive higher priority advert = false
 Gratuitous ARP interval = 0
 Gratuitous NA interval = 0
 VRRP default protocol version = 2
 Iptables input chain = INPUT
 Using ipsets = true
 ipset IPv4 address set = keepalived
 ipset IPv6 address set = keepalived6
 ipset IPv6 address,iface set = keepalived_if6
 VRRP check unicast_src = false
 VRRP skip check advert addresses = false
 VRRP strict mode = false
 VRRP process priority = 0
 VRRP don't swap = false
 Checker process priority = 0
 Checker don't swap = false
 SNMP keepalived disabled
 SNMP checker disabled
 SNMP RFCv2 disabled
 SNMP RFCv3 disabled
 SNMP traps disabled
 SNMP socket = default (unix:/var/agentx/master)
 Network namespace = (default)
 Script security disabled
 Default script uid:gid 0:0
------< SSL definitions >------
 Using autogen SSL context
Keepalived_vrrp exited with permanent error CONFIG. Terminating
Stopping
Stopped
Unexpected argument(s): | tee /var/log/keepalived.log
Stopped Keepalived v1.3.5 (03/19,2017), git commit v1.3.5-6-g6fa32f2
Unexpected argument(s): | tee /var/log/keepalived.log

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/669702

[Sagi (Sergey) Shnaidman (sshnaidm)]

Should be fixed by https://review.opendev.org/#/c/669702/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/669702
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=5eb012b4f62615519707a926cc62528f5dc54a44
Submitter: Zuul
Branch: stable/rocky

commit 5eb012b4f62615519707a926cc62528f5dc54a44
Author: Alex Schultz <email address hidden>
Date: Tue Jan 22 17:37:29 2019 -0700

    Fix interface_for_ip for newer facter versions

    In facter 3.x, the networking facts are in a complex hash. Previously
    the interface facts where flat so we would lookup the vars. This change
    first tries the facter 2.x lookup before falling back to the facter 3.x
    syntax.

    Closes-Bug: #1835718
    Change-Id: I260b18ae3479da4f5176027d4b26b3e1c6b22063
    Closes-Bug: #1812938
    (cherry picked from commit 5fff984cecf68c256e60ba6017f37b9d1e76e31b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.5.1 release.