puppet-snmp has broken puppet-tripleo unit tests due to structured facts

[Alex Schultz]

https://github.com/voxpupuli/puppet-snmp/pull/154

http://logs.openstack.org/93/614593/2/check/puppet-openstack-unit-4.8-centos-7/468e926/job-output.txt.gz#_2018-10-31_20_07_57_683896

018-10-31 20:07:57.683896 | centos-7 | 1) tripleo::profile::base::snmp on centos-7-x86_64 behaves like tripleo::profile::base::snmp with default configuration should configure snmpd
2018-10-31 20:07:57.683994 | centos-7 | Failure/Error:
2018-10-31 20:07:57.684150 | centos-7 | is_expected.to contain_class('snmp').with(
2018-10-31 20:07:57.684262 | centos-7 | :snmpd_config => [
2018-10-31 20:07:57.684431 | centos-7 | 'createUser ro_snmp_user MD5 "secrete"',
2018-10-31 20:07:57.684577 | centos-7 | 'rouser ro_snmp_user',
2018-10-31 20:07:57.684682 | centos-7 | 'proc cron',
2018-10-31 20:07:57.684814 | centos-7 | 'includeAllDisks 10%',
2018-10-31 20:07:57.684928 | centos-7 | 'master agentx',
2018-10-31 20:07:57.685070 | centos-7 | 'trapsink localhost public',
2018-10-31 20:07:57.685212 | centos-7 | 'iquerySecName internalUser',
2018-10-31 20:07:57.685337 | centos-7 | 'rouser internalUser',
2018-10-31 20:07:57.685396 | centos-7 |
2018-10-31 20:07:57.685529 | centos-7 | Puppet::PreformattedError:
2018-10-31 20:07:57.685978 | centos-7 | Evaluation Error: Operator '[]' is not applicable to an Undef Value. at /home/zuul/workspace/spec/fixtures/modules/snmp/manifests/params.pp:35:14 on node centos-7-rax-ord-0000236464
2018-10-31 20:07:57.686290 | centos-7 | Shared Example Group: "tripleo::profile::base::snmp" called from ./spec/classes/tripleo_profile_base_snmp_spec.rb:80

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/614647

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614647
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=040857a738492514bc7b65f18ad89922a1ccb16e
Submitter: Zuul
Branch: master

commit 040857a738492514bc7b65f18ad89922a1ccb16e
Author: Alex Schultz <email address hidden>
Date: Wed Oct 31 16:30:08 2018 -0600

    Pin puppet-snmp

    They updated to structured facts but rspect-puppet-facts isn't providing
    them at this time. Pin to a previous version.

    Change-Id: I8798a5c40951867250f84b053fa3be744f6aef32
    Closes-Bug: #1800944

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/614771

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/614773

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614771
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=b6ed72c67f3142b8c24f250a1d3cf53499c4c247
Submitter: Zuul
Branch: stable/rocky

commit b6ed72c67f3142b8c24f250a1d3cf53499c4c247
Author: Alex Schultz <email address hidden>
Date: Wed Oct 31 16:30:08 2018 -0600

    Pin puppet-snmp

    They updated to structured facts but rspect-puppet-facts isn't providing
    them at this time. Pin to a previous version.

    Change-Id: I8798a5c40951867250f84b053fa3be744f6aef32
    Closes-Bug: #1800944
    (cherry picked from commit 040857a738492514bc7b65f18ad89922a1ccb16e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/614773
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=b43dc05ddd1591dcad06e3c3b29717c7537231a6
Submitter: Zuul
Branch: stable/queens

commit b43dc05ddd1591dcad06e3c3b29717c7537231a6
Author: Alex Schultz <email address hidden>
Date: Wed Oct 31 16:30:08 2018 -0600

    Pin puppet-snmp

    They updated to structured facts but rspect-puppet-facts isn't providing
    them at this time. Pin to a previous version.

    Change-Id: I8798a5c40951867250f84b053fa3be744f6aef32
    Closes-Bug: #1800944
    (cherry picked from commit 040857a738492514bc7b65f18ad89922a1ccb16e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 10.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.4.0 release.