ceph-nfs duplicate property

Bug #1798020 reported by Michele Baldessari
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Michele Baldessari

Bug Description

In change I78c16c9fb28211a7a8ec2187ae76b9a072b76ea2 we eliminated
startup races with ceph nfs, but we need to make sure we do
not create duplicate properies or puppet will fail because we create the pacemaker property twice for the bootstrap host

Revision history for this message
Michele Baldessari (michele) wrote :
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/609599
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=7e3219ff2b2ec3fdd43f0dd26dc487b78ccbf3eb
Submitter: Zuul
Branch: master

commit 7e3219ff2b2ec3fdd43f0dd26dc487b78ccbf3eb
Author: Michele Baldessari <email address hidden>
Date: Thu Oct 11 08:47:26 2018 +0200

    Fix ceph-nfs duplicate property

    In change I78c16c9fb28211a7a8ec2187ae76b9a072b76ea2 we eliminated
    startup races with ceph nfs, but we need to make sure we do
    not create duplicate properies or puppet will fail.

    While we're at it we also point the bootstrapnode at
    ceph_nfs_short_bootstrap_node_name instead of which is more correct.
    It is functionally the same if ceph-nfs and manila-share run on the
    same nodes, which is likely the case in most cases, but best
    make it correct while we're at it.

    Closes-Bug: #1798020

    Change-Id: I5a41f95b2d91a25fe617afb9ada0b5201d2b7ef7

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/611203

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/rocky)

Reviewed: https://review.openstack.org/611203
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=148347b2d0f4a31547ea98f0cb3d6129360225c1
Submitter: Zuul
Branch: stable/rocky

commit 148347b2d0f4a31547ea98f0cb3d6129360225c1
Author: Michele Baldessari <email address hidden>
Date: Thu Oct 11 08:47:26 2018 +0200

    Fix ceph-nfs duplicate property

    In change I78c16c9fb28211a7a8ec2187ae76b9a072b76ea2 we eliminated
    startup races with ceph nfs, but we need to make sure we do
    not create duplicate properies or puppet will fail.

    While we're at it we also point the bootstrapnode at
    ceph_nfs_short_bootstrap_node_name instead of which is more correct.
    It is functionally the same if ceph-nfs and manila-share run on the
    same nodes, which is likely the case in most cases, but best
    make it correct while we're at it.

    Closes-Bug: #1798020

    Change-Id: I5a41f95b2d91a25fe617afb9ada0b5201d2b7ef7
    (cherry picked from commit 7e3219ff2b2ec3fdd43f0dd26dc487b78ccbf3eb)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/611274

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/queens)

Reviewed: https://review.openstack.org/611274
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=6a6f932efc652e25416020c2687398cb5c4094ea
Submitter: Zuul
Branch: stable/queens

commit 6a6f932efc652e25416020c2687398cb5c4094ea
Author: Michele Baldessari <email address hidden>
Date: Thu Oct 11 08:47:26 2018 +0200

    Fix ceph-nfs duplicate property

    In change I78c16c9fb28211a7a8ec2187ae76b9a072b76ea2 we eliminated
    startup races with ceph nfs, but we need to make sure we do
    not create duplicate properies or puppet will fail.

    While we're at it we also point the bootstrapnode at
    ceph_nfs_short_bootstrap_node_name instead of which is more correct.
    It is functionally the same if ceph-nfs and manila-share run on the
    same nodes, which is likely the case in most cases, but best
    make it correct while we're at it.

    Closes-Bug: #1798020

    Change-Id: I5a41f95b2d91a25fe617afb9ada0b5201d2b7ef7
    (cherry picked from commit 7e3219ff2b2ec3fdd43f0dd26dc487b78ccbf3eb)
    (cherry picked from commit 148347b2d0f4a31547ea98f0cb3d6129360225c1)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 10.1.0

This issue was fixed in the openstack/puppet-tripleo 10.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 8.4.0

This issue was fixed in the openstack/puppet-tripleo 8.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 9.4.0

This issue was fixed in the openstack/puppet-tripleo 9.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.