tripleo

bad nic_alias fact warning in docker-puppet

Bug #1794837 reported by Alex Schultz on 2018-09-27

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Medium	Alex Schultz	tripleo stein-1

Bug Description

In docker puppet output we can see:

018-09-27 00:34:45 | "Warning: Facter: Could not retrieve fact='nic_alias', resolution='<anonymous>': Could not execute '/usr/bin/os-net-config -i': command not found",

This should be fixed in the nic_alias fact to skip if os-net-config does not exist.

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-09-27: Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/605811

Changed in tripleo:
assignee:	nobody → Alex Schultz (alex-schultz)
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-05: Change abandoned on puppet-tripleo (master)

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/605811
Reason: we need https://review.openstack.org/#/c/607966/

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-06: Fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/605811
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=6fb8797f79b9d71d25afc8db1937cea539ee24ec
Submitter: Zuul
Branch: master

commit 6fb8797f79b9d71d25afc8db1937cea539ee24ec
Author: Alex Schultz <email address hidden>
Date: Thu Sep 27 11:03:11 2018 -0600

Fix nic_alias fact error

    If os-net-config is not installed, this fact causes a warning to be
    generated. Let's check for os-net-config prior to trying to run it to
    cleanup this error.

Change-Id: Ie55b96bbd7b60dae2342b89c24936d4d071cec10
Closes-Bug: #1794837

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-09: Fix proposed to puppet-tripleo (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/609088

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-10-14: Fix merged to puppet-tripleo (stable/rocky)

Reviewed: https://review.openstack.org/609088
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=123be2924e299a439b16c24bc9ce7349f06eb93c
Submitter: Zuul
Branch: stable/rocky

commit 123be2924e299a439b16c24bc9ce7349f06eb93c
Author: Alex Schultz <email address hidden>
Date: Thu Sep 27 11:03:11 2018 -0600

Fix nic_alias fact error

    If os-net-config is not installed, this fact causes a warning to be
    generated. Let's check for os-net-config prior to trying to run it to
    cleanup this error.

    Change-Id: Ie55b96bbd7b60dae2342b89c24936d4d071cec10
    Closes-Bug: #1794837
    (cherry picked from commit 6fb8797f79b9d71d25afc8db1937cea539ee24ec)