[manila] Dell/EMC backends require value for share_backend_name

[Goutham Pacha Ravi]

Description
===========

Heat templates for configuring manila with Dell/EMC backends (VNX, VMAX, Unity and Isilon) must always specify the value for "share_backend_name". Although, the corresponding base template files in tripleo-heat-templates/tree/puppet/services/manila-backend-{vnx,vmax,unity,isilon) do not have this parameter.

This parameter has a default value in puppet-manila [1][2][3][4] that will being ignored in effect if it is added in the base templates.

[1] https://github.com/openstack/puppet-manila/blob/8a5105/manifests/backend/dellemc_vnx.pp#L67
[2] https://github.com/openstack/puppet-manila/blob/8a5105/manifests/backend/dellemc_vmax.pp#L67
[3] https://github.com/openstack/puppet-manila/blob/9f65ebe/manifests/backend/dellemc_unity.pp#L85
[4] https://github.com/openstack/puppet-manila/blob/5b74b8/manifests/backend/dellemc_isilon.pp#L63

Steps to Reproduce
==================
Deploy Triple-O with manila enabled in the overcloud, and specify a heat template for any of the EMC/Dell backends (it isn't necessary to have a valid storage system, make up a fake IP for emc_nas_server, the manila-share service can fail to come up, but the deployment must go through).
You can see that the 'manila::backend::dellemc_*::share_backend_name' parameter has no effect.

Environment
===========
OpenStack Pike with Dell/EMC VNX (as reported in https://bugs.launchpad.net/tripleo/+bug/1771179)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/568945

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/568945
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=3d0451285166193337ad3ece6031e1564a82d4b0
Submitter: Zuul
Branch: master

commit 3d0451285166193337ad3ece6031e1564a82d4b0
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed May 16 12:43:25 2018 -0700

    Remove share_backend_name from Dell-EMC manila backends

    This parameter has a default value from puppet-manila
    ex: [1], and doesn't need to be specified here.

    [1] https://git.openstack.org/cgit/openstack/puppet-manila/tree/manifests/backend/dellemc_unity.pp

    Change-Id: I7fa8ffd9af459f138bc182fd6bd307471c87f75d
    Closes-Bug: #1771656

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/572931

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/572931
Reason: we have gate problems again, please do not restore or recheck, I'll take care of this one when gate is back stable.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/572931
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=bd3302815a7ae09399a6817fb5e91a6153255c47
Submitter: Zuul
Branch: stable/queens

commit bd3302815a7ae09399a6817fb5e91a6153255c47
Author: Goutham Pacha Ravi <email address hidden>
Date: Wed May 16 12:43:25 2018 -0700

    Remove share_backend_name from Dell-EMC manila backends

    This parameter has a default value from puppet-manila
    ex: [1], and doesn't need to be specified here.

    [1] https://git.openstack.org/cgit/openstack/puppet-manila/tree/manifests/backend/dellemc_unity.pp

    Change-Id: I7fa8ffd9af459f138bc182fd6bd307471c87f75d
    Closes-Bug: #1771656
    (cherry picked from commit 3d0451285166193337ad3ece6031e1564a82d4b0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.3.4 release.