puppet-tripleo unit tests broken due to changes in puppet-systemd

[Alex Schultz]

A recent change to move parameter data using the data-in-modules format has broken puppet-tripleo since we are not using puppet >= 4.10.0.

https://github.com/camptocamp/puppet-systemd/commit/973badec577dee794b4ec1edb5217c8d51be9e9c

http://logs.openstack.org/72/550872/2/check/puppet-openstack-unit-4.8-centos-7/597012d/job-output.txt.gz#_2018-03-12_08_52_38_259289
2018-03-12 08:52:38.259289 | centos-7 | 1) tripleo::profile::base::aodh::api on centos-7-x86_64 behaves like tripleo::profile::base::aodh::api with step 3 and bootstrap should trigger complete configuration
2018-03-12 08:52:38.259400 | centos-7 | Failure/Error: include systemd
2018-03-12 08:52:38.259426 | centos-7 |
2018-03-12 08:52:38.259481 | centos-7 | Puppet::PreformattedError:
2018-03-12 08:52:38.259649 | centos-7 | Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Class[Systemd]:
2018-03-12 08:52:38.259742 | centos-7 | expects a value for parameter 'service_limits'
2018-03-12 08:52:38.259826 | centos-7 | expects a value for parameter 'manage_resolved'
2018-03-12 08:52:38.259906 | centos-7 | expects a value for parameter 'resolved_ensure'
2018-03-12 08:52:38.259985 | centos-7 | expects a value for parameter 'manage_networkd'
2018-03-12 08:52:38.260064 | centos-7 | expects a value for parameter 'networkd_ensure'
2018-03-12 08:52:38.260145 | centos-7 | expects a value for parameter 'manage_timesyncd'
2018-03-12 08:52:38.260225 | centos-7 | expects a value for parameter 'timesyncd_ensure'
2018-03-12 08:52:38.260298 | centos-7 | expects a value for parameter 'ntp_server'
2018-03-12 08:52:38.260601 | centos-7 | expects a value for parameter 'fallback_ntp_server' at /home/zuul/workspace/spec/fixtures/modules/systemd/manifests/dropin_file.pp:39:3 at /home/zuul/workspace/spec/fixtures/modules/tripleo/manifests/profile/base/apache.pp:39 on node centos-7-inap-mtl01-0002895293

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/552060

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/552165

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/552167

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/552168

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552060
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=bd5599ca59b168ce4785991c4165fa4196b8d78a
Submitter: Zuul
Branch: master

commit bd5599ca59b168ce4785991c4165fa4196b8d78a
Author: Alex Schultz <email address hidden>
Date: Mon Mar 12 09:37:03 2018 -0600

    Pin puppet-systemd

    puppet-systemd recently added a breaking change to pull the module
    parameter defaults via hiera. This only works in puppet >= 4.10.0 which
    we are not using. So we need to pin to an earlier commit since we're
    usign 4.8.x.

    Change-Id: I11c8372eb20d9ff67bcc91897118061d7f193a54
    Closes-Bug: #1755211

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552165
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=3a443b3c055784a87cb59299ca171e4c9f0fee1b
Submitter: Zuul
Branch: stable/queens

commit 3a443b3c055784a87cb59299ca171e4c9f0fee1b
Author: Alex Schultz <email address hidden>
Date: Mon Mar 12 09:37:03 2018 -0600

    Pin puppet-systemd

    puppet-systemd recently added a breaking change to pull the module
    parameter defaults via hiera. This only works in puppet >= 4.10.0 which
    we are not using. So we need to pin to an earlier commit since we're
    usign 4.8.x.

    Change-Id: I11c8372eb20d9ff67bcc91897118061d7f193a54
    Closes-Bug: #1755211
    (cherry picked from commit bd5599ca59b168ce4785991c4165fa4196b8d78a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552168
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=598c7129e3692a4ef43b3c588f5ac48afa050deb
Submitter: Zuul
Branch: stable/ocata

commit 598c7129e3692a4ef43b3c588f5ac48afa050deb
Author: Alex Schultz <email address hidden>
Date: Mon Mar 12 09:37:03 2018 -0600

    Pin puppet-systemd

    puppet-systemd recently added a breaking change to pull the module
    parameter defaults via hiera. This only works in puppet >= 4.10.0 which
    we are not using. So we need to pin to an earlier commit since we're
    usign 4.8.x.

    Change-Id: I11c8372eb20d9ff67bcc91897118061d7f193a54
    Closes-Bug: #1755211
    (cherry picked from commit 8777c2911a2de899bf0cb58487973962cf3ebcee)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552167
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=8777c2911a2de899bf0cb58487973962cf3ebcee
Submitter: Zuul
Branch: stable/pike

commit 8777c2911a2de899bf0cb58487973962cf3ebcee
Author: Alex Schultz <email address hidden>
Date: Mon Mar 12 09:37:03 2018 -0600

    Pin puppet-systemd

    puppet-systemd recently added a breaking change to pull the module
    parameter defaults via hiera. This only works in puppet >= 4.10.0 which
    we are not using. So we need to pin to an earlier commit since we're
    usign 4.8.x.

    Change-Id: I11c8372eb20d9ff67bcc91897118061d7f193a54
    Closes-Bug: #1755211
    (cherry picked from commit bd5599ca59b168ce4785991c4165fa4196b8d78a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.4.11 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 6.5.11 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.0.0 release.