logging: wrong fluentd configuration when service_configuration is used

[Juan Badia Payno]

Deploy tripleo with logging enabled (fluentd) and configure fluentd to have one file per service, it ended up with a failed deployment with the following error:

2018-01-31 10:44:19Z [overcloud]: CREATE_FAILED Resource CREATE failed: Error: resources.AllNodesDeploySteps.resources.ComputeDeployment_Step4.resources[0]: Deployment to server failed: deploy_status_code: Deployment exited with non-zero status code: 2

 Stack overcloud CREATE_FAILED

overcloud.AllNodesDeploySteps.ComputeDeployment_Step4.0:
  resource_type: OS::Heat::StructuredDeployment
  physical_resource_id: dbd1ad65-ee9f-4683-b7e1-f3b23648109b
  status: CREATE_FAILED
  status_reason: |
    Error: resources[0]: Deployment to server failed: deploy_status_code : Deployment exited with non-zero status code: 2
  deploy_stdout: |
    ...
            "Warning: This method is deprecated, please use match expressions with Stdlib::Compat::String instead. They are described at https://docs.puppet.com/puppet/latest/reference/lang_data_type.html#match-expressions. at [\"/etc/puppet/modules/snmp/manifests/params.pp\", 310]:[\"/var/lib/tripleo-config/puppet_step_config.pp\", 50]",
            "Warning: ModuleLoader: module 'oslo' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules",
            "Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: The value 'tag' cannot be converted to Numeric. at /etc/puppet/modules/tripleo/manifests/profile/base/logging/fluentd/fluentd_service.pp:52:46 at /etc/puppet/modules/tripleo/manifests/profile/base/logging/fluentd.pp:123 on node overcloud-novacompute-0.localdomain"
        ]
    }
     to retry, use: --limit @/var/lib/heat-config/heat-config-ansible/e8d37e1e-2153-47ac-8d90-5cff59796019_playbook.retry

    PLAY RECAP *********************************************************************
    localhost : ok=4 changed=1 unreachable=0 failed=1

    (truncated, view all with --long)
  deploy_stderr: |

Heat Stack create failed.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/539110
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=42a869fcf4b13cd8f1c88b0ec2ff5efefe8d2e0f
Submitter: Zuul
Branch: master

commit 42a869fcf4b13cd8f1c88b0ec2ff5efefe8d2e0f
Author: Juan Badia Payno <email address hidden>
Date: Tue Jan 30 07:59:50 2018 +0100

    Fluentd: fixed configuration by service

    The configuration file by service was not
    properly configured.

    Also clean some double tasks on the tests

    Change-Id: I3149902401d68d6fd236073a73a20f982d4b952a
    Closes-Bug: #1746952
    Related-Bug: #1715187

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.3.0 release.