NFS backup driver

Bug #1744174 reported by Marc Methot
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Marc Methot

Bug Description

Hardcoded values prevent use of nfs as a cinder backup driver

https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/cinder-backup.yaml#L12
  CinderBackupBackend:
    default: swift
    description: The short name of the Cinder Backup backend to use.
    type: string
    constraints:
- allowed_values: ['swift', 'ceph']

This forces to use less intuitive methods of configuring it and made me think twice as to why it wasn't an allowed value.
puppet-cinder already has everything we need to configure NFS so no changes needed there.

-MM

Marc Methot (mb-methot)
Changed in tripleo:
assignee: nobody → Marc (mb-methot)
Changed in tripleo:
milestone: none → queens-3
importance: Undecided → Medium
milestone: queens-3 → rocky-1
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/535776

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/552542

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Marc Methot (<email address hidden>) on branch: master
Review: https://review.openstack.org/552542
Reason: failed to amend to my original commit

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-tripleo (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/553640

Changed in tripleo:
assignee: Marc (mb-methot) → Alan Bishop (alan-bishop)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/553640
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=364c76158f171102fbb7c1d18bcae7c5ad877a8c
Submitter: Zuul
Branch: master

commit 364c76158f171102fbb7c1d18bcae7c5ad877a8c
Author: Alan Bishop <email address hidden>
Date: Thu Mar 15 19:32:14 2018 -0400

    Add NFS backend for cinder-backup service

    Add a Cinder backup profile that uses NFS for the backend.

    Related-Bug: #1744174
    Change-Id: Ic0adb294aa2e60243f8adaf167bdd75e42c8e20e

Changed in tripleo:
assignee: Alan Bishop (alan-bishop) → Marc (mb-methot)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/535776
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e456e103fbfb5d7dd12f4dcbee4fd6686384117c
Submitter: Zuul
Branch: master

commit e456e103fbfb5d7dd12f4dcbee4fd6686384117c
Author: Marc Methot <email address hidden>
Date: Fri Jan 19 09:14:55 2018 -0500

    Add nfs as a cinder backup driver option to CinderBackupBackend

    Added nfs as an option to where CinderBackupBackend was hardcoded
    as either ceph or swift. Also added some parameters for this
    driver - CinderBackupNfsShare and CinderBackupNfsMountOptions

    Depends-On: Ic0adb294aa2e60243f8adaf167bdd75e42c8e20e
    Change-Id: I29a488374726676a28fb82f2f950db891fcf9627
    Closes-Bug: #1744174

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.0.0.0b2

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-tripleo (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/574707

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/574708

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-tripleo (stable/queens)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/queens
Review: https://review.openstack.org/574707
Reason: we have gate problems again, please do not restore or recheck, I'll take care of this one when gate is back stable.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-tripleo (stable/queens)

Reviewed: https://review.openstack.org/574707
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=58c881a3692d1efffb317804b022971733ddc2ef
Submitter: Zuul
Branch: stable/queens

commit 58c881a3692d1efffb317804b022971733ddc2ef
Author: Alan Bishop <email address hidden>
Date: Thu Mar 15 19:32:14 2018 -0400

    Add NFS backend for cinder-backup service

    Add a Cinder backup profile that uses NFS for the backend.

    Related-Bug: #1744174
    Change-Id: Ic0adb294aa2e60243f8adaf167bdd75e42c8e20e
    (cherry picked from commit 364c76158f171102fbb7c1d18bcae7c5ad877a8c)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.openstack.org/574708
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=542e2bbee1efc007e9fed6915e9d064558b1172c
Submitter: Zuul
Branch: stable/queens

commit 542e2bbee1efc007e9fed6915e9d064558b1172c
Author: Marc Methot <email address hidden>
Date: Fri Jan 19 09:14:55 2018 -0500

    Add nfs as a cinder backup driver option to CinderBackupBackend

    Added nfs as an option to where CinderBackupBackend was hardcoded
    as either ceph or swift. Also added some parameters for this
    driver - CinderBackupNfsShare and CinderBackupNfsMountOptions

    Depends-On: Ic0adb294aa2e60243f8adaf167bdd75e42c8e20e
    Change-Id: I29a488374726676a28fb82f2f950db891fcf9627
    Closes-Bug: #1744174
    (cherry picked from commit e456e103fbfb5d7dd12f4dcbee4fd6686384117c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.4

This issue was fixed in the openstack/tripleo-heat-templates 8.0.4 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.