Iscsid container gets wrong volume for puppet generated configs

[Bogdan Dobrelya]

Puppet generates configs for iscsid in /etc/iscsi. The volume mounted for the tht's iscsid containerized service template is empty and gets no configuration. Therefore nova_compute, cinder_volume and iscsid containers failing to start cuz of ' __:MissingRequiredSource: /var/lib/kolla/config_files/src-iscsid/* file is not found'.

I can reproduce it with all-in-one containerized undercloud, using this composable services list https://github.com/bogdando/oooq-warp/blob/dev/tht/environments/all-in-one.yaml

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/524187

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/526390

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/526390
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=5fb0826ee2d45e1a20e6adbc273d34b4636be0fc
Submitter: Zuul
Branch: master

commit 5fb0826ee2d45e1a20e6adbc273d34b4636be0fc
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Dec 7 14:36:55 2017 +0100

    Bind-mount iscsid IQN by its real host path

    Containerized or running on baremetal services
    on a node must use the same iSCSI Qualified Name (IQN).
    However, overcloud nodes must have a unique IQN.

    Tht's puppet config bind mounts the real hosts' /etc/iscsid
    directory so that puppet ensures the IQN is unique and
    is reset once, and only once.

    Switch the host path bind mount for cinder bundles to catch up
    that configuration path as well.

    Related-bug: #1735425

    Change-Id: I7e9f0641164691682516ac3e72e2145c7d112409
    Co-authored-by: Alan Bishop <email address hidden>
    Co-authored-by: Martin André <email address hidden>
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/524187
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=82f128f15b1b1eb7bf6ac7df0c6d01e5619309eb
Submitter: Zuul
Branch: master

commit 82f128f15b1b1eb7bf6ac7df0c6d01e5619309eb
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Nov 30 15:10:52 2017 +0100

    Fix puppet config volume for iscsid in containers

    Bind mount the /etc/iscsi host path for iscsi container puppet config.
    Use the real host path /etc/iscsi for containers dependsing on it.

    Closes-bug: #1735425

    Change-Id: I838427ccae06cfe1be72939c4bcc2978f7dc36a8
    Depends-on: I7e9f0641164691682516ac3e72e2145c7d112409
    Co-authored-by: Alan Bishop <email address hidden>
    Co-authored-by: Martin André <email address hidden>
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/pike
Review: https://review.openstack.org/531679

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/531680

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/531679

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/531680

[Bogdan Dobrelya (bogdando)]

Additional to fix (instead of reverts) https://review.openstack.org/532134

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531679
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=c67619413e611b492a011383d5a47a4ddeb658c6
Submitter: Zuul
Branch: stable/pike

commit c67619413e611b492a011383d5a47a4ddeb658c6
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Dec 7 14:36:55 2017 +0100

    Bind-mount iscsid IQN by its real host path

    Containerized or running on baremetal services
    on a node must use the same iSCSI Qualified Name (IQN).
    However, overcloud nodes must have a unique IQN.

    Tht's puppet config bind mounts the real hosts' /etc/iscsid
    directory so that puppet ensures the IQN is unique and
    is reset once, and only once.

    Switch the host path bind mount for cinder bundles to catch up
    that configuration path as well.

    Related-bug: #1735425

    Change-Id: I7e9f0641164691682516ac3e72e2145c7d112409
    Co-authored-by: Alan Bishop <email address hidden>
    Co-authored-by: Martin André <email address hidden>
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 5fb0826ee2d45e1a20e6adbc273d34b4636be0fc)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/531680
Reason: https://review.openstack.org/#/c/533373/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/533373
Reason: https://review.openstack.org/#/c/533380/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/533380
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=fa02a8f8633b682ba2042ac7fb26d76453cfe65a
Submitter: Zuul
Branch: stable/pike

commit fa02a8f8633b682ba2042ac7fb26d76453cfe65a
Author: John Fulton <email address hidden>
Date: Fri Jan 5 15:26:22 2018 -0500

    Align stars to fix stable/pike gate on scenario001

    1) Fix path for iscsi config file

    We changed the bind mount to be /etc/iscsi in
    I838427ccae06cfe1be72939c4bcc2978f7dc36a8, we need to copy the files to
    /etc/iscsi so that they do not end up at '/' in the container.

    Change-Id: Id5c1f16d08ffd36a35a6669d64460a7b2240d401
    Closes-Bug: #1741850
    (cherry picked from commit 8eb351d588539c20caf768c2633832a924f40690)

    2) Fix puppet config volume for iscsid in containers

    Bind mount the /etc/iscsi host path for iscsi container puppet config.
    Use the real host path /etc/iscsi for containers dependsing on it.

    Closes-bug: #1735425

    Change-Id: I838427ccae06cfe1be72939c4bcc2978f7dc36a8
    Co-authored-by: Alan Bishop <email address hidden>
    Co-authored-by: Martin André <email address hidden>
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 82f128f15b1b1eb7bf6ac7df0c6d01e5619309eb)

    3) Allow to override manage polling param

    Without this, we cannot override the polling yaml metrics
    from puppet template.

    Change-Id: I509dd4932402c458e222c52b5d7d5e370a5466c0
    (cherry picked from commit e870783b2c8f3b7b13459693b17425f5bf0fe53d)

    4) Disable voting on scenario001 - now timeouting to ssh the VM created
       by Tempest.

    Related-Bug: 1742936

    5) Update Ceph container CPU/memory limits in Ceph scenarios

    Ceph containers are started with `docker run --memory`
    and `docker run --cpus` to limit their memory and CPU
    resources. The defaults for OSD and MDS containers were
    recently increased [1] to values better for production
    but this change keeps them at lower values just for
    CI.

    [1] https://github.com/ceph/ceph-ansible/pull/2304

    Change-Id: I5b5cf5cc52907af092bea5e162d4b577ee05c23a
    Related-Bug: 1741499
    (cherry picked from commit d68619a26ec7cbd6176f4bb0d352d2aa91439f5c)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: stable/pike
Review: https://review.openstack.org/531680
Reason: https://review.openstack.org/#/c/533380/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 7.0.8 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b3 development milestone.