tuned-adm fails on undercloud-containers

[Michele Baldessari]

With https://review.openstack.org/#/c/511509 we start erroring out properly on puppet errors.
One of the jobs that is now failing is:
http://logs.openstack.org/09/511509/7/check/legacy-tripleo-ci-centos-7-undercloud-containers/5d3fecc/logs/var/log/undercloud_install.txt.gz

Reason for this is that we include the tripleo::base::tuned profile which has:
  exec { 'tuned-adm':
    path => ['/bin', '/usr/bin', '/sbin', '/usr/sbin'],
    command => "tuned-adm profile ${profile}",
    unless => "tuned-adm active | grep -q '${profile}'"
  }

So if the tuned package is not installed by other means we get:
"Error: /Stage[main]/Tripleo::Profile::Base::Tuned/Exec[tuned-adm]: Could not evaluate: Could not find command 'tuned-adm'",

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/512993

[Alex Schultz (alex-schultz)]

https://bugs.launchpad.net/tripleo/+bug/1709982 was the original bug that had this documented, i'll dupe it of this one since there is a patch proposed for this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/513261

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/513261
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=1e9000a4347eda009e59548353cfb3be5e661231
Submitter: Zuul
Branch: stable/pike

commit 1e9000a4347eda009e59548353cfb3be5e661231
Author: Michele Baldessari <email address hidden>
Date: Wed Oct 18 12:00:21 2017 +0200

    Make sure tuned package is installed before calling tuned-adm

    With https://review.openstack.org/#/c/511509 we start erroring out
    properly on puppet errors. One of the jobs that is now failing is:

    http://logs.openstack.org/09/511509/7/check/legacy-tripleo-ci-centos-7-undercloud-containers/5d3fecc/logs/var/log/undercloud_install.txt.gz

    Reason for this is that we include the tripleo::base::tuned profile which has:
      exec { 'tuned-adm':
        path => ['/bin', '/usr/bin', '/sbin', '/usr/sbin'],
        command => "tuned-adm profile ${profile}",
        unless => "tuned-adm active | grep -q '${profile}'"
      }

    So if the tuned package is not installed by other means we get:
    "Error: /Stage[main]/Tripleo::Profile::Base::Tuned/Exec[tuned-adm]: Could not evaluate: Could not find command 'tuned-adm'",

    Let's add the package here in the profile instead of installing it
    via tripleo.sh, that way also a split stack deployment is covered.

    Change-Id: I130cdc59000e0c5e5fa7c542fbe6b782651a7eb7
    Closes-Bug: #1724518
    (cherry picked from commit 32ef340901027926ed3f77ae37d8e0d20e38e15d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.4.3 release.