puppet-tripleo .gitignore is masking the hiera files used by tests

Bug #1691559 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Alex Schultz

Bug Description

In puppet-tripleo the .gitignore includes spec/fixtures but the problem is that we have static files in the git report for hieradata used by testing in spec/fixtures/{hiera.yaml,hieradata}. The gitignore should be updated so we stop skipping these files. It also has the side effect of causing files to be excluded from the tarballs which leads to interesting problems downstream.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/465738

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/465738
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=66b6ea166c0f8470170f6e07843ff41068d8e9e9
Submitter: Jenkins
Branch: master

commit 66b6ea166c0f8470170f6e07843ff41068d8e9e9
Author: Alex Schultz <email address hidden>
Date: Wed May 17 14:45:35 2017 -0600

    Update gitignore not to exclude fixture hieradata

    The existing .gitignore is causing the hieradata we use for tests to be
    excluded in git and our release tarballs. Lets adjust the gitignore not
    to exclude the hiera files in spec/fixtures

    Change-Id: Ic31687d0eb1c2e8acc92796d4c0eba096db8e533
    Closes-Bug: #1691559

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/466370

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/466372

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/ocata)

Reviewed: https://review.openstack.org/466370
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=220fa8d8fa22da3db0c5e798ba2ee84b6586727d
Submitter: Jenkins
Branch: stable/ocata

commit 220fa8d8fa22da3db0c5e798ba2ee84b6586727d
Author: Alex Schultz <email address hidden>
Date: Wed May 17 14:45:35 2017 -0600

    Update gitignore not to exclude fixture hieradata

    The existing .gitignore is causing the hieradata we use for tests to be
    excluded in git and our release tarballs. Lets adjust the gitignore not
    to exclude the hiera files in spec/fixtures

    Change-Id: Ic31687d0eb1c2e8acc92796d4c0eba096db8e533
    Closes-Bug: #1691559
    (cherry picked from commit 66b6ea166c0f8470170f6e07843ff41068d8e9e9)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/newton)

Reviewed: https://review.openstack.org/466372
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=62f1bf7e957ef10037590899c2d396c2984b2d02
Submitter: Jenkins
Branch: stable/newton

commit 62f1bf7e957ef10037590899c2d396c2984b2d02
Author: Alex Schultz <email address hidden>
Date: Wed May 17 14:45:35 2017 -0600

    Update gitignore not to exclude fixture hieradata

    The existing .gitignore is causing the hieradata we use for tests to be
    excluded in git and our release tarballs. Lets adjust the gitignore not
    to exclude the hiera files in spec/fixtures

    Change-Id: Ic31687d0eb1c2e8acc92796d4c0eba096db8e533
    Closes-Bug: #1691559
    (cherry picked from commit 66b6ea166c0f8470170f6e07843ff41068d8e9e9)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 7.1.0

This issue was fixed in the openstack/puppet-tripleo 7.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 6.5.0

This issue was fixed in the openstack/puppet-tripleo 6.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 5.6.1

This issue was fixed in the openstack/puppet-tripleo 5.6.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.