horizon gets deconfigued in step3 of updates

[Alex Schultz]

horizon gets deconfigured during update runs on an deployed cloud.

Steps to reproduce:
1) deploy overcloud
2) run deploy overcloud again
3) look at logs and notice that the horizon configuration is removed (in step3) and reapplied (in step4) of the subsequent run.

Logs:
step3 logs http://paste.openstack.org/show/605110/
step4 logs http://paste.openstack.org/show/605111/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/452349

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/452349
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=e2928717412242faa4eb15d778f1b5c0952edc08
Submitter: Jenkins
Branch: master

commit e2928717412242faa4eb15d778f1b5c0952edc08
Author: Alex Schultz <email address hidden>
Date: Fri Mar 31 17:41:36 2017 -0600

    Move horizon to step 3

    We configure apache in step 3 so horizon should be configured at the
    same time or else updates will cause horizon to be unvailable during the
    update process.

    Change-Id: I4032f7c24edc0ff9ed637e213870cdd3beb9a54e
    Closes-Bug: #1678338

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/452785

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/452785
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=3424991c39e27e434bd61d3964bf578695fc767c
Submitter: Jenkins
Branch: stable/ocata

commit 3424991c39e27e434bd61d3964bf578695fc767c
Author: Alex Schultz <email address hidden>
Date: Fri Mar 31 17:41:36 2017 -0600

    Move horizon to step 3

    We configure apache in step 3 so horizon should be configured at the
    same time or else updates will cause horizon to be unvailable during the
    update process.

    Change-Id: I4032f7c24edc0ff9ed637e213870cdd3beb9a54e
    Closes-Bug: #1678338
    (cherry picked from commit e2928717412242faa4eb15d778f1b5c0952edc08)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/452977

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/452977
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=f206c2c431e809c0058378b7288026be29361aaa
Submitter: Jenkins
Branch: stable/newton

commit f206c2c431e809c0058378b7288026be29361aaa
Author: Alex Schultz <email address hidden>
Date: Fri Mar 31 17:41:36 2017 -0600

    Move horizon to step 3

    We configure apache in step 3 so horizon should be configured at the
    same time or else updates will cause horizon to be unvailable during the
    update process.

    Change-Id: I4032f7c24edc0ff9ed637e213870cdd3beb9a54e
    Closes-Bug: #1678338
    (cherry picked from commit e2928717412242faa4eb15d778f1b5c0952edc08)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 5.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 6.4.0 release.