norpm provider doesn't support virtual_packages causing unnecessary service restarts

Bug #1665405 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Emilien Macchi

Bug Description

In puppet-tripleo we have a norpm provider that is supposed to prevent the packages from being installed but it's still querying the rpm db for the package. Unfortunately it doesn't support virtual_packages which means that some packages are still attempted to be installed which can trigger unncessary service restarts every time.

Example:

include ::tripleo::packages
include ::swift::client

will result in python-swiftclient being "installed" because it does not find python2-swiftclient which causes swift service restarts. The norpm provider prevents it from actually installing anything but puppet still sees a change and schedules refreshes.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/435011

Changed in tripleo:
assignee: nobody → Alex Schultz (alex-schultz)
status: New → In Progress
tags: added: newton-backport-potential ocata-backport-potential
Changed in tripleo:
assignee: Alex Schultz (alex-schultz) → Emilien Macchi (emilienm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/435181

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/ocata)

Reviewed: https://review.openstack.org/435181
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=81071f69e9efdc185f36ff68fda70d4d468da987
Submitter: Jenkins
Branch: stable/ocata

commit 81071f69e9efdc185f36ff68fda70d4d468da987
Author: Alex Schultz <email address hidden>
Date: Thu Feb 16 09:53:55 2017 -0700

    Add virtual_packages support to norpm provider

    The norpm provider is supposed to noop package installs/updates but if a
    package name in puppet does not match the installed package, it is being
    reported as not installed. The provider then 'installs' it every time
    which can trigger unwanted service restarts.

    Change-Id: Icdfa6567168f9ecc555489ed67405f98544bd910
    Closes-Bug: #1665405
    (cherry picked from commit 525a2c379ba2e2433217af2aa78018dfd8cb0b44)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.openstack.org/435011
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=bb9dba181965e101f586240462ff72f882f7ae90
Submitter: Jenkins
Branch: master

commit bb9dba181965e101f586240462ff72f882f7ae90
Author: Alex Schultz <email address hidden>
Date: Thu Feb 16 09:53:55 2017 -0700

    Add virtual_packages support to norpm provider

    The norpm provider is supposed to noop package installs/updates but if a
    package name in puppet does not match the installed package, it is being
    reported as not installed. The provider then 'installs' it every time
    which can trigger unwanted service restarts.

    Change-Id: Icdfa6567168f9ecc555489ed67405f98544bd910
    Closes-Bug: #1665405

Changed in tripleo:
status: In Progress → Fix Released
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/437701

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/newton)

Reviewed: https://review.openstack.org/437701
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=a3e20cdf1f7efedbf7f91b7b5211a8682c622f3f
Submitter: Jenkins
Branch: stable/newton

commit a3e20cdf1f7efedbf7f91b7b5211a8682c622f3f
Author: Alex Schultz <email address hidden>
Date: Thu Feb 16 09:53:55 2017 -0700

    Add virtual_packages support to norpm provider

    The norpm provider is supposed to noop package installs/updates but if a
    package name in puppet does not match the installed package, it is being
    reported as not installed. The provider then 'installs' it every time
    which can trigger unwanted service restarts.

    Change-Id: Icdfa6567168f9ecc555489ed67405f98544bd910
    Closes-Bug: #1665405
    (cherry picked from commit bb9dba181965e101f586240462ff72f882f7ae90)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 6.3.0

This issue was fixed in the openstack/puppet-tripleo 6.3.0 release.

tags: added: idempotency
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 7.0.0

This issue was fixed in the openstack/puppet-tripleo 7.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 5.6.0

This issue was fixed in the openstack/puppet-tripleo 5.6.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.