tempest::tempest_config_file is not fully honored

[Takashi Kajinami]

The tempest class provides the tempest_config_file to customize path of the tempest.conf .

However this parameter is not honored properly.

 - When install_from_source is true, this parameter is not at all userd

 - When install_from_source is false, this parameter is used by tempest_conf resource but
   is not used by the other setters.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-tempest/+/900621

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tempest/+/900621
Committed: https://opendev.org/openstack/puppet-tempest/commit/dbef30e09b89317500c0c6c4cd24d3de38ac2bf5
Submitter: "Zuul (22348)"
Branch: master

commit dbef30e09b89317500c0c6c4cd24d3de38ac2bf5
Author: Takashi Kajinami <email address hidden>
Date: Fri Nov 10 23:28:55 2023 +0900

    Deprecate confusing tempest_config_file

    The tempest_config_file parameter is supposed to determine the path of
    tempest.conf but this is not working completely.

    * This parameter is ignored when install_from_source is true

    * This parameter affects tempest_conf when install_from_source but
      some resources like tempest_flavor_id_setter uses a fixed path.

    This deprecates the parameter to avoid complexity. Especially the 2nd
    behavior is quite confusing and requires users to set two independent
    parameters with "consistent" values.

    Closes-Bug: #2043210
    Change-Id: Ica5e77dff0d76250835b9187e292c2384d02b683

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tempest 24.0.0 release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-tempest/+/916572

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-tempest/+/916572
Committed: https://opendev.org/openstack/puppet-tempest/commit/e82a668c4028c28c1aa49ecd703a968552aba8dc
Submitter: "Zuul (22348)"
Branch: master

commit e82a668c4028c28c1aa49ecd703a968552aba8dc
Author: Takashi Kajinami <email address hidden>
Date: Sat Apr 20 23:19:57 2024 +0900

    magnum: Deprecate tempest_config_file

    ... because we deprecated the same parameter of the tempest class.

    Related-Bug: #2043210
    Change-Id: I87c1db9a9d5297da4f5a716faa44f0228203893d