Bad logic in pipeline check causes spurious warning
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cisco Openstack |
Fix Released
|
Low
|
Mark T. Voelker | ||
puppet-swift |
Fix Released
|
Undecided
|
Mark T. Voelker | ||
Havana |
Fix Committed
|
Undecided
|
Unassigned |
Bug Description
The puppet-swift module's storage::server class features this piece of code:
# TODO if array does not include type-server, warn
if(
(is_
$pipeline != "${type}-server"
) {
warning(
}
There's a logic error here. For example, if $pipeline is an array with a member "${type}-server", warning triggers because the $pipeline != "${type}-server" part of the check evaluates to true (since $pipeline is an array, not a string). Since the two conditions are or'd together, if either evaluate to true warning triggers.
Since the only impact of the logic bug is a warning, the impact is relatively small: users will get spooked by a warning that shouldn't be there, but Swift services will still work.
Changed in puppet-swift: | |
status: | New → In Progress |
assignee: | nobody → Mark T. Voelker (mvoelker) |
Changed in openstack-cisco: | |
milestone: | none → h.3 |
importance: | Undecided → Low |
assignee: | nobody → Mark T. Voelker (mvoelker) |
status: | New → In Progress |
Changed in openstack-cisco: | |
status: | In Progress → Fix Committed |
Changed in openstack-cisco: | |
status: | Fix Committed → Fix Released |
Changed in puppet-swift: | |
milestone: | none → 4.0.0 |
status: | Fix Committed → Fix Released |
Fix proposed to branch: master /review. openstack. org/78888
Review: https:/